Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for OpenTofu runner #1067

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Updates for OpenTofu runner #1067

merged 4 commits into from
Mar 18, 2024

Conversation

sudhir-kelkar
Copy link
Contributor

No description provided.

@Fryguy Fryguy changed the title WIP: ManageIQ installer updates for OpenTofu runner [WIP] ManageIQ installer updates for OpenTofu runner Mar 11, 2024
@Fryguy Fryguy changed the title [WIP] ManageIQ installer updates for OpenTofu runner [WIP] Updates for OpenTofu runner Mar 11, 2024
@Fryguy Fryguy assigned bdunne and unassigned agrare Mar 11, 2024
@miq-bot miq-bot added the wip label Mar 11, 2024
bdunne
bdunne reviewed Mar 13, 2024
View reviewed changes
Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just the test failure or is there another reason this is marked as WIP?

manageiq-operator/api/v1alpha1/helpers/miq-components/orchestrator.go Outdated Show resolved Hide resolved
manageiq-operator/api/v1alpha1/manageiq_types.go Outdated Show resolved Hide resolved
manageiq-operator/config/crd/bases/manageiq.org_manageiqs.yaml Outdated Show resolved Hide resolved
@sudhir-kelkar
Copy link
Contributor Author

Is it just the test failure or is there another reason this is marked as WIP?

For Test Failure... My Dev environment crashed. Creating new environment which will have docker on it.

@Fryguy
Copy link
Member

Fryguy commented Mar 13, 2024

@sudhir-kelkar Please do a rebase instead of merging master into the branch as per #1067 (comment)

@agrare agrare mentioned this pull request Mar 14, 2024
Merged
7 tasks
@miq-bot
Copy link
Member

miq-bot commented Mar 18, 2024

Checked commits sudhir-kelkar/manageiq-pods@681124b~...ad342ce with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@sudhir-kelkar sudhir-kelkar changed the title [WIP] Updates for OpenTofu runner Updates for OpenTofu runner Mar 18, 2024
@miq-bot miq-bot removed the wip label Mar 18, 2024
@bdunne bdunne merged commit f999473 into ManageIQ:master Mar 18, 2024
2 checks passed
@sudhir-kelkar sudhir-kelkar deleted the opentofu-runner branch March 21, 2024 05:04
@Fryguy Fryguy mentioned this pull request Mar 26, 2024
Closed
40 tasks
@Fryguy
Copy link
Member

Fryguy commented Mar 28, 2024

Backported to radjabov in commit 0667319.

commit 0667319181739d66d9f40df9f9563fe9c0b73204
Author: Brandon Dunne <brandondunne@hotmail.com>
Date:   Mon Mar 18 14:04:10 2024 -0400

    Merge pull request #1067 from sudhir-kelkar/opentofu-runner
    
    Updates for OpenTofu runner
    
    (cherry picked from commit f999473017ea779efda8cfb37619cce551d19a93)

Fryguy pushed a commit that referenced this pull request Mar 28, 2024
@bdunne @Fryguy
Merge pull request #1067 from sudhir-kelkar/opentofu-runner
0667319 
Updates for OpenTofu runner

(cherry picked from commit f999473)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare left review comments

@bdunne bdunne bdunne left review comments

@Fryguy Fryguy Fryguy left review comments

Assignees

@bdunne bdunne

Labels
enhancement radjabov/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sudhir-kelkar @Fryguy @miq-bot @bdunne @agrare