refresh name from volume_name #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lauferin
requested review from
agrare,
Fryguy,
ereztheodorou,
erantzabari,
llivne and
gregoryb-at-ibm
as code owners
Lauferin
force-pushed
the
adrian/392778-change_volume_name_field
branch
from
788dc00
to
7119eea
Compare
agrare
reviewed
Nov 9, 2022
spec/models/manageiq/providers/autosde/storage_manager/refresher_spec.rb
Outdated
Show resolved
Hide resolved
Lauferin
force-pushed
the
adrian/392778-change_volume_name_field
branch
4 times, most recently
from
459e8ee
to
bf89bdc
Compare
Lauferin
force-pushed
the
adrian/392778-change_volume_name_field
branch
from
bf89bdc
to
7e83301
Compare
|
Checked commit Autosde@7e83301 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
|
Ok, now tests work :-) |
agrare
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a change in the volume model of autosde. The field 'name' in volume now includes the storage system and pool name, and the specific name is now in field volume_name, which is the one that manageIQ should show. Not doing that leaves two problems: 1) it doesn't look good (see image below) and 2) autosde's rest receives a name and adds to it the pool and storage, so if we send it already with that data the name just grows on and on...