Removed unused refresh parser code #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hard to say no to a PR with deletes ✂️ 🔥 |
|
Yeah there are still some callers of RefreshParser code (mainly for host smartstate) e.g. https://github.com/ManageIQ/manageiq-providers-vmware/blob/master/app/models/manageiq/providers/vmware/infra_manager/host_esx.rb#L84-L93 and https://github.com/ManageIQ/manageiq-providers-vmware/blob/master/app/models/manageiq/providers/vmware/infra_manager/host_esx.rb#L95-L105 so I'm going to make sure those are covered by spec tests so we know it is safe to delete the rest of this |
Now that graph refresh is the only option we can cleanup a lot of old refresh parser code.
agrare
force-pushed
the
cleanup_old_refresh_parser_code
branch
2 times, most recently
from
40cc8c6
to
045849c
Compare
agrare
force-pushed
the
cleanup_old_refresh_parser_code
branch
from
045849c
to
37e453b
Compare
|
Checked commits agrare/manageiq-providers-vmware@bd8dbd8~...18f6308 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint |
agrare
changed the title
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that graph refresh is the only option we can cleanup a lot of old
refresh parser code.