Merge pull request #6426 from hstastna/Check_Compliance_Last_Known_Config_VM

Enable Check Compliance toolbar button for nested list of VMs and make it work

Author: martinpovolny

app/controllers/application_controller/ci_processing.rb

@@ -388,6 +388,18 @@ def retirevms_now
 
   def check_compliance_vms
     assert_privileges(params[:pressed])
+
+    records = find_records_with_rbac(record_class, checked_or_params)
+    # Check each record if there is any compliance policy assigned to it
+    if records.any? { |record| !record.has_compliance_policies? }
+      javascript_flash(
+        :text       => _('No Compliance Policies assigned to one or more of the selected items'),
+        :severity   => :error,
+        :scroll_top => true
+      )
+      return
+    end
+
     generic_button_operation('check_compliance_queue', _('Check Compliance'), vm_button_action)
   end
   alias image_check_compliance check_compliance_vms
@@ -616,15 +628,21 @@ def generic_button_operation(action, action_name, operation, options = {})
   def testable_action(action)
     controller = params[:controller]
     vm_infra_untestable_actions = %w[check_compliance_queue destroy refresh_ems vm_miq_request_new]
-    ems_cluster_untestable_actions = %w[scan]
-    if controller == "vm_infra"
-      return vm_infra_untestable_actions.exclude?(action)
-    end
-    if controller == "ems_cluster" || @display == 'ems_clusters'
-      return ems_cluster_untestable_actions.exclude?(action)
+    ems_cluster_untestable_actions = %w[check_compliance_queue scan]
+    other_untestable_actions = %w[check_compliance_queue]
+
+    return false if @display == 'ems_clusters' && action == 'scan'
+
+    case controller
+    when 'ems_cluster'
+      ems_cluster_untestable_actions.exclude?(action)
+    when 'auth_key_pair_cloud', 'availability_zone', 'cloud_network', 'cloud_tenant', 'ems_cloud', 'ems_infra', 'flavor', 'host', 'host_aggregate', 'resource_pool', 'storage', 'vm_cloud'
+      other_untestable_actions.exclude?(action)
+    when 'vm_infra'
+      vm_infra_untestable_actions.exclude?(action)
+    else
+      true
     end
-
-    true
   end
 
   # Maps UI actions to queryable feature in case it is not possible

app/controllers/ems_cluster_controller.rb

@@ -89,7 +89,7 @@ def button
     elsif @refresh_div == "main_div" && @lastaction == "show_list"
       replace_gtl_main_div
     else
-      render_flash
+      render_flash unless performed?
     end
   end
 

app/controllers/host_controller.rb

@@ -349,7 +349,7 @@ def button
     elsif @refresh_div == "main_div" && @lastaction == "show_list"
       replace_gtl_main_div
     else
-      render_flash
+      render_flash unless performed?
     end
   end
 

app/controllers/resource_pool_controller.rb

@@ -58,7 +58,7 @@ def button
     elsif @refresh_div == "main_div" && @lastaction == "show_list"
       replace_gtl_main_div
     else
-      render_flash
+      render_flash unless performed?
     end
   end
 

app/helpers/application_helper/toolbar/vm_clouds_center.rb

@@ -122,7 +122,7 @@ class ApplicationHelper::Toolbar::VmCloudsCenter < ApplicationHelper::Toolbar::B
           :url_parms    => "main_div",
           :send_checked => true,
           :confirm      => N_("Initiate Check Compliance of the last known configuration for the selected items?"),
-          :enabled      => false,
+          :enabled      => true,
           :onwhen       => "1+",
           :klass        => ApplicationHelper::Button::InstanceCheckCompare),
       ]

app/helpers/application_helper/toolbar/vm_infras_center.rb

@@ -151,7 +151,7 @@ class ApplicationHelper::Toolbar::VmInfrasCenter < ApplicationHelper::Toolbar::B
           :url_parms    => "main_div",
           :send_checked => true,
           :confirm      => N_("Initiate Check Compliance of the last known configuration for the selected items?"),
-          :enabled      => false,
+          :enabled      => true,
           :onwhen       => "1+",
           :klass        => ApplicationHelper::Button::VmCheckCompliance),
       ]

spec/controllers/auth_key_pair_cloud_controller_spec.rb

@@ -99,4 +99,38 @@
       end
     end
   end
+
+  describe '#button' do
+    context 'Check Compliance of Last Known Configuration on Instances' do
+      let(:vm_instance) { FactoryBot.create(:vm_or_template) }
+
+      before do
+        allow(controller).to receive(:assert_privileges)
+        allow(controller).to receive(:drop_breadcrumb)
+        allow(controller).to receive(:performed?).and_return(true)
+        allow(controller).to receive(:render)
+        controller.instance_variable_set(:@display, 'instances')
+        controller.params = {:miq_grid_checks => vm_instance.id.to_s, :pressed => 'instance_check_compliance', :id => kp.id.to_s, :controller => 'auth_key_pair_cloud'}
+      end
+
+      it 'does not initiate Check Compliance because of missing Compliance policies' do
+        controller.send(:button)
+        expect(controller.instance_variable_get(:@flash_array)).to eq([{:message => 'No Compliance Policies assigned to one or more of the selected items', :level => :error}])
+      end
+
+      context 'VM Compliance policy set' do
+        let(:policy) { FactoryBot.create(:miq_policy, :mode => 'compliance', :towhat => 'Vm', :active => true) }
+
+        before do
+          vm_instance.add_policy(policy)
+          allow(MiqPolicy).to receive(:policy_for_event?).and_return(true)
+        end
+
+        it 'initiates Check Compliance action' do
+          controller.send(:button)
+          expect(controller.instance_variable_get(:@flash_array)).to eq([{:message => 'Check Compliance initiated for 1 VM and Instance from the ManageIQ Database', :level => :success}])
+        end
+      end
+    end
+  end
 end

spec/controllers/availability_zone_controller_spec.rb

@@ -1,42 +1,64 @@
 describe AvailabilityZoneController do
   describe "#show" do
+    let(:params) { {:id => zone.id} }
+    let(:zone) { FactoryBot.create(:availability_zone) }
+
     before do
       EvmSpecHelper.create_guid_miq_server_zone
-      @zone = FactoryBot.create(:availability_zone)
       login_as FactoryBot.create(:user_admin)
     end
 
-    subject do
-      get :show, :params => {:id => @zone.id}
+    subject { get :show, :params => params }
+
+    render_views
+
+    it 'renders listnav partial' do
+      is_expected.to have_http_status 200
+      is_expected.to render_template(:partial => "layouts/listnav/_availability_zone")
     end
 
-    context "render listnav partial" do
-      render_views
+    context 'display timeline' do
+      let(:params) { {:id => zone.id, :display => 'timeline'} }
 
-      it do
+      it 'renders listnav partial' do
         is_expected.to have_http_status 200
         is_expected.to render_template(:partial => "layouts/listnav/_availability_zone")
       end
     end
   end
 
-  describe "#show display=timeline" do
-    before do
-      EvmSpecHelper.create_guid_miq_server_zone
-      @zone = FactoryBot.create(:availability_zone)
-      login_as FactoryBot.create(:user_admin)
-    end
+  describe '#button' do
+    context 'Check Compliance of Last Known Configuration on Instances' do
+      let(:vm_instance) { FactoryBot.create(:vm_or_template) }
+      let(:av_zone) { FactoryBot.create(:availability_zone) }
 
-    subject do
-      get :show, :params => {:id => @zone.id, :display => 'timeline'}
-    end
+      before do
+        allow(controller).to receive(:assert_privileges)
+        allow(controller).to receive(:drop_breadcrumb)
+        allow(controller).to receive(:performed?).and_return(true)
+        allow(controller).to receive(:render)
+        controller.instance_variable_set(:@display, 'instances')
+        controller.params = {:miq_grid_checks => vm_instance.id.to_s, :pressed => 'instance_check_compliance', :id => av_zone.id.to_s, :controller => 'availability_zone'}
+      end
 
-    context "render listnav partial" do
-      render_views
+      it 'does not initiate Check Compliance because of missing Compliance policies' do
+        controller.send(:button)
+        expect(controller.instance_variable_get(:@flash_array)).to eq([{:message => 'No Compliance Policies assigned to one or more of the selected items', :level => :error}])
+      end
 
-      it do
-        is_expected.to have_http_status 200
-        is_expected.to render_template(:partial => "layouts/listnav/_availability_zone")
+      context 'VM Compliance policy set' do
+        let(:policy) { FactoryBot.create(:miq_policy, :mode => 'compliance', :towhat => 'Vm', :active => true) }
+
+        before do
+          EvmSpecHelper.create_guid_miq_server_zone
+          vm_instance.add_policy(policy)
+          allow(MiqPolicy).to receive(:policy_for_event?).and_return(true)
+        end
+
+        it 'initiates Check Compliance action' do
+          controller.send(:button)
+          expect(controller.instance_variable_get(:@flash_array)).to eq([{:message => 'Check Compliance initiated for 1 VM and Instance from the ManageIQ Database', :level => :success}])
+        end
       end
     end
   end

spec/controllers/cloud_tenant_controller_spec.rb

@@ -40,6 +40,38 @@
         controller.send(:button)
       end
     end
+
+    context 'Check Compliance of Last Known Configuration on Instances' do
+      let(:vm_instance) { FactoryBot.create(:vm_or_template) }
+
+      before do
+        allow(controller).to receive(:assert_privileges)
+        allow(controller).to receive(:drop_breadcrumb)
+        allow(controller).to receive(:performed?).and_return(true)
+        allow(controller).to receive(:render)
+        controller.instance_variable_set(:@display, 'instances')
+        controller.params = {:miq_grid_checks => vm_instance.id.to_s, :pressed => 'instance_check_compliance', :id => tenant.id.to_s, :controller => 'cloud_tenant'}
+      end
+
+      it 'does not initiate Check Compliance because of missing Compliance policies' do
+        controller.send(:button)
+        expect(controller.instance_variable_get(:@flash_array)).to eq([{:message => 'No Compliance Policies assigned to one or more of the selected items', :level => :error}])
+      end
+
+      context 'VM Compliance policy set' do
+        let(:policy) { FactoryBot.create(:miq_policy, :mode => 'compliance', :towhat => 'Vm', :active => true) }
+
+        before do
+          vm_instance.add_policy(policy)
+          allow(MiqPolicy).to receive(:policy_for_event?).and_return(true)
+        end
+
+        it 'initiates Check Compliance action' do
+          controller.send(:button)
+          expect(controller.instance_variable_get(:@flash_array)).to eq([{:message => 'Check Compliance initiated for 1 VM and Instance from the ManageIQ Database', :level => :success}])
+        end
+      end
+    end
   end
 
   describe "#tags_edit" do

spec/controllers/ems_cloud_controller_spec.rb

@@ -1,6 +1,7 @@
 describe EmsCloudController do
   let!(:server) { EvmSpecHelper.local_miq_server(:zone => zone) }
   let(:zone) { FactoryBot.build(:zone) }
+
   describe "#create" do
     before do
       allow(controller).to receive(:check_privileges).and_return(true)
@@ -264,7 +265,7 @@
     end
   end
 
-  context "#build_credentials only contains credentials that it supports and has a username for in params" do
+  describe "#build_credentials only contains credentials that it supports and has a username for in params" do
     let(:mocked_ems)    { double(ManageIQ::Providers::Openstack::CloudManager) }
     let(:default_creds) { {:userid => "default_userid", :password => "default_password"} }
     let(:amqp_creds)    { {:userid => "amqp_userid",    :password => "amqp_password"} }
@@ -294,7 +295,7 @@
     end
   end
 
-  context "#update_ems_button_validate" do
+  describe "#update_ems_button_validate" do
     let(:mocked_ems) { FactoryBot.create(:ems_openstack) }
 
     it "calls authentication_check with save = false" do
@@ -308,8 +309,9 @@
     end
   end
 
-  context "#create_ems_button_validate" do
+  describe "#create_ems_button_validate" do
     let(:mocked_params) { {:controller => mocked_class_controller, :cred_type => "default"} }
+
     before do
       allow(controller).to receive(:render)
       controller.params = mocked_params
@@ -668,9 +670,8 @@
 
   describe "#sync_users" do
     let(:ems) { FactoryBot.create(:ems_openstack_with_authentication) }
-    before do
-      stub_user(:features => :all)
-    end
+
+    before { stub_user(:features => :all) }
 
     it "redirects when request is successful" do
       expect(controller).to receive(:find_record_with_rbac).and_return(ems)
@@ -717,6 +718,7 @@ def verify_password_and_confirm(password, verify)
 
   context "'Set Default' button rendering in listnav" do
     render_views
+
     before do
       stub_user(:features => :all)
       EvmSpecHelper.create_guid_miq_server_zone
@@ -783,4 +785,38 @@ def verify_password_and_confirm(password, verify)
 
     include_examples 'hiding tenant column for non admin user', :name => "Name", :emstype_description => "Type"
   end
+
+  describe '#button' do
+    context 'Check Compliance of Last Known Configuration on Instances' do
+      let(:vm_instance) { FactoryBot.create(:vm_or_template) }
+      let(:ems) { FactoryBot.create(:ems_openstack) }
+
+      before do
+        allow(controller).to receive(:assert_privileges)
+        allow(controller).to receive(:performed?).and_return(true)
+        allow(controller).to receive(:render)
+        controller.instance_variable_set(:@display, 'instances')
+        controller.params = {:miq_grid_checks => vm_instance.id.to_s, :pressed => 'instance_check_compliance', :id => ems.id.to_s, :controller => 'ems_cloud'}
+      end
+
+      it 'does not initiate Check Compliance because of missing Compliance policies' do
+        controller.send(:button)
+        expect(controller.instance_variable_get(:@flash_array)).to eq([{:message => 'No Compliance Policies assigned to one or more of the selected items', :level => :error}])
+      end
+
+      context 'VM Compliance policy set' do
+        let(:policy) { FactoryBot.create(:miq_policy, :mode => 'compliance', :towhat => 'Vm', :active => true) }
+
+        before do
+          vm_instance.add_policy(policy)
+          allow(MiqPolicy).to receive(:policy_for_event?).and_return(true)
+        end
+
+        it 'initiates Check Compliance action' do
+          controller.send(:button)
+          expect(controller.instance_variable_get(:@flash_array)).to eq([{:message => 'Check Compliance initiated for 1 VM and Instance from the ManageIQ Database', :level => :success}])
+        end
+      end
+    end
+  end
 end