Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI specs by adding persistent user|group|role object #3533

Merged
merged 4 commits into from
Mar 8, 2018
Merged

Fix CI specs by adding persistent user|group|role object #3533

merged 4 commits into from
Mar 8, 2018

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Mar 7, 2018 •
edited
Loading

We are not using users|groups|role with establishing relations them and we are using for some specs objects created from these models but only in memory, without ids. And it is causing problems.

CI failure:
https://travis-ci.org/ManageIQ/manageiq-ui-classic/jobs/350401089

Links

Progress

fixed:

  • /spec/controllers/ops_controller_spec.rb
  • /spec/helpers/application_helper/views_shared_spec.rb
  • /spec/presenters/tree_builder_ops_rbac_spec.rb
  • /spec/controllers/ops_controller/ops_rbac_spec.rb

@miq-bot miq-bot added the wip label Mar 7, 2018
@mzazrivec mzazrivec self-assigned this Mar 8, 2018
@himdel himdel mentioned this pull request Mar 8, 2018
Merged
@lpichler lpichler force-pushed the fix_user_related_specs_with_adding_created_user branch from 2084c9c to fc417c8 Compare March 8, 2018 12:55
This was referenced Mar 8, 2018
Merged
Merged
@lpichler lpichler changed the title [WIP] Fix CI specs by adding persistent user|group|role object Fix CI specs by adding persistent user|group|role object Mar 8, 2018
@miq-bot miq-bot removed the wip label Mar 8, 2018
@miq-bot
Copy link
Member

miq-bot commented Mar 8, 2018

Checked commits lpichler/manageiq-ui-classic@fc417c8~...ff1cc4d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 0 offenses detected
Everything looks fine. 🍪

@dclarizio dclarizio added the test label Mar 8, 2018
@dclarizio dclarizio assigned dclarizio and unassigned mzazrivec Mar 8, 2018
@dclarizio dclarizio merged commit 63dbf09 into ManageIQ:master Mar 8, 2018
@dclarizio dclarizio added this to the Sprint 81 Ending Mar 12, 2018 milestone Mar 8, 2018
@lpichler lpichler deleted the fix_user_related_specs_with_adding_created_user branch March 9, 2018 09:35
@lpichler
Copy link
Contributor Author

lpichler commented Mar 9, 2018

@simaishi

@miq-bot fine/yes

fixing CI, thanks to fix for
https://bugzilla.redhat.com/show_bug.cgi?id=1544875

@miq-bot
Copy link
Member

miq-bot commented Mar 9, 2018

@lpichler unrecognized command 'fine', ignoring...

Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@lpichler
Copy link
Contributor Author

lpichler commented Mar 9, 2018

@miq-bot add_label fine/yes

simaishi pushed a commit that referenced this pull request Mar 9, 2018
@simaishi
Merge pull request #3533 from lpichler/fix_user_related_specs_with_ad…
999a3e2 
…ding_created_user

Fix CI specs by adding persistent user|group|role object
(cherry picked from commit 63dbf09)
@simaishi
Copy link
Contributor

simaishi commented Mar 9, 2018

Gaprindashvili backport details:

$ git log -1
commit 999a3e2f280b5e5f1cbb46ed4b9afa06f8046e04
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Thu Mar 8 12:32:37 2018 -0800

    Merge pull request #3533 from lpichler/fix_user_related_specs_with_adding_created_user
    
    Fix CI specs by adding persistent user|group|role object
    (cherry picked from commit 63dbf0995b7a5384dcc0c180de1d1a3db0947829)

@lpichler lpichler mentioned this pull request Apr 12, 2018
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dclarizio dclarizio

Labels
gaprindashvili/backported test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lpichler @miq-bot @simaishi @dclarizio @mzazrivec