Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] jasmine: expose config as json endpoint #5459

Closed
wants to merge 1 commit into from
Closed

[WIP] jasmine: expose config as json endpoint #5459

wants to merge 1 commit into from

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Apr 16, 2019

(Built on top of #5458, first commit)

Exposes jasmine.yml config to the test environment as a JSON GET endpoint.

Because right now, we have to run jasmine with ?random=false in the url because the JS can't read the config.

TODO: the jasmine index html/js changes
(also, maybe this won't be necessary on our side, depends on jasmine/jasmine-gem#307)

to query the `jasmine.yml` config from the JS side,
to prevent having to pass `?random=true` in the URL
@miq-bot
Copy link
Member

miq-bot commented Apr 16, 2019

Checked commit https://github.com/himdel/manageiq-ui-classic/commit/ec67253a2abec7dae605d4971781d4b6e9b53f17 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

spec/javascripts/support/jasmine_helper.rb

  • ⚠️ - Line 55, Col 12 - Lint/UnusedMethodArgument - Unused method argument - env. If it's necessary, use _ or _env as an argument name to indicate that it won't be used. You can also write as call(*) if you want the method to accept any arguments but don't care about them.

@miq-bot miq-bot closed this Oct 21, 2019
@miq-bot
Copy link
Member

miq-bot commented Oct 21, 2019

This pull request has been automatically closed because it has not been updated for at least 6 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions!

@himdel himdel deleted the jasmine-config branch October 21, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants