Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completely remove gettext catalogs #6160

Merged
merged 3 commits into from
Sep 9, 2019
Merged

Completely remove gettext catalogs #6160

merged 3 commits into from
Sep 9, 2019

Conversation

mzazrivec
Copy link
Contributor

@mzazrivec mzazrivec commented Sep 6, 2019 •
edited
Loading

  • the translations now live in core repo only
  • we don't need these files in plugins at all
  • also remove gettext initialization from the plugin (it's not needed now)
  • remove :placeholders spec (not needed now)

@miq-bot
Copy link
Member

miq-bot commented Sep 6, 2019

Checked commits mzazrivec/manageiq-ui-classic@8db9418~...4670108 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@martinpovolny
Copy link
Member

Ivanchuk/no I assume?

@martinpovolny martinpovolny self-assigned this Sep 9, 2019
@martinpovolny martinpovolny added this to the Sprint 120 Ending Sep 16, 2019 milestone Sep 9, 2019
@martinpovolny martinpovolny merged commit 66379ac into ManageIQ:master Sep 9, 2019
@mzazrivec mzazrivec deleted the completely_remove_gettext_catalogs branch September 9, 2019 13:21
@mzazrivec
Copy link
Contributor Author

@martinpovolny Yep, ivanchuk/no. Label added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
cleanup internationalization ivanchuk/no
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mzazrivec @miq-bot @martinpovolny