Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthenticationAPI - use base64encode which can deal with UTF8 passwords #1411

Merged
merged 5 commits into from
Mar 28, 2018
Merged

AuthenticationAPI - use base64encode which can deal with UTF8 passwords #1411

merged 5 commits into from
Mar 28, 2018

Commits on Mar 26, 2018

  1. Remove angular-base64

    suffers from the same problem as window.btoa - can't handle unicode strings
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1527316
    himdel committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    83273df View commit details
    Browse the repository at this point in the history
  2. base64encode - a utf-8 aware base64encode implementation

    `window.btoa("sněhulák")` fails on InvalidCharacterError: String contains an invalid character
    
    because it only expects latin1 chars
    
    `$base64.encode` from `angular-base64` has the same problem.
    
    We need to base64 encode the login:password pair even when the password uses non-latin1 chars :)
    
    Implementation adapted from https://developer.mozilla.org/en-US/docs/Web/API/WindowBase64/Base64_encoding_and_decoding#Solution_2_%E2%80%93_rewrite_the_DOMs_atob()_and_btoa()_using_JavaScript's_TypedArrays_and_UTF-8
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1527316
    himdel committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    c635a8a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bdbc83b View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2018

  1. AuthenticationApi - update TextEncoderLite to a version which exports…

    … the encoder
    
    and explicitly say window.TextEncoder for when it doesn't exist
    himdel committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    1384c4a View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2018

  1. Use concise repo reference

    AllenBW committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    eeb03c9 View commit details
    Browse the repository at this point in the history