Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

[Part 2/3 of BZ#1789479] UI changes for UCI: disable CPU throttling, accept TLS certificates for both RHV and OSP conv hosts #1099

Merged
merged 5 commits into from
Feb 10, 2020
Merged

[Part 2/3 of BZ#1789479] UI changes for UCI: disable CPU throttling, accept TLS certificates for both RHV and OSP conv hosts #1099

merged 5 commits into from
Feb 10, 2020

Conversation

mturley
Copy link
Contributor

@mturley mturley commented Jan 29, 2020 •
edited
Loading

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1789479
JIRA: https://issues.redhat.com/browse/MIGENG-316

Depends on: ManageIQ/manageiq#19787
Depends on: ManageIQ/manageiq-api#732

This will probably conflict with #1103 when backporting, and it would be harmless to backport #1103, so we may want to.

This PR wraps up the UI changes necessary for UCI support as discussed with @fdupont-redhat in the BZ:

  • CPU throttling is removed from the General tab of the settings page.
  • In the Configure Conversion Host wizard on the Authentication step, the "Verify TLS Certificates for OpenStack" toggle has been renamed to "Verify TLS Certificates" and made available for RHV targets in addition to OSP ones.
  • The certificate field itself has been renamed from "OpenStack Trusted CA Certificates" to "Trusted CA Certificates".
  • The API property used for certificates when POSTing the results of the wizard has been changed from openstack_tls_ca_certs to tls_ca_certs.

Screens

General settings, before:

Screenshot 2020-01-29 17 05 38

General settings, after:

Screenshot 2020-01-29 17 36 00

Authentication step of the conversion host wizard:

Screenshot 2020-02-07 16 04 22

@mturley mturley added enhancement bz Issues filed by QE or having a BZ wip v1.3 UI Issues and PRs related only to the UI ivanchuk/yes labels Jan 29, 2020
@miq-bot
Copy link
Member

miq-bot commented Feb 7, 2020

Checked commits mturley/manageiq-v2v@416a0c9~...b2a4cc5 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@mturley mturley removed the wip label Feb 7, 2020
@mturley mturley changed the title [WIP] [Part 2/2 of BZ#1789479] UI changes for UCI: disable CPU throttling, accept TLS certificates for both RHV and OSP conv hosts [Part 2/2 of BZ#1789479] UI changes for UCI: disable CPU throttling, accept TLS certificates for both RHV and OSP conv hosts Feb 7, 2020
@mzazrivec mzazrivec self-assigned this Feb 10, 2020
@mzazrivec mzazrivec merged commit c74f1b3 into ManageIQ:master Feb 10, 2020
@mturley mturley deleted the ui-changes-for-uci-2 branch February 10, 2020 16:29
@mturley mturley changed the title [Part 2/2 of BZ#1789479] UI changes for UCI: disable CPU throttling, accept TLS certificates for both RHV and OSP conv hosts [Part 2/3 of BZ#1789479] UI changes for UCI: disable CPU throttling, accept TLS certificates for both RHV and OSP conv hosts Feb 19, 2020
@simaishi
Copy link
Contributor

simaishi commented Feb 24, 2020 •
edited
Loading

@mturley another one with conflicts (even with #1103)

@mturley
Copy link
Contributor Author

mturley commented Feb 24, 2020

Looking at it now @simaishi

@mturley mturley mentioned this pull request Feb 24, 2020
Merged
@mturley
Copy link
Contributor Author

mturley commented Feb 24, 2020

@simaishi : #1113

@mturley mturley mentioned this pull request Feb 24, 2020
Merged
simaishi added a commit that referenced this pull request Feb 24, 2020
@simaishi
Merge pull request #1113 from mturley/pr1099-ivanchuk-backport
d015f38 
[IVANCHUK] Backport for #1099 ([Part 2/3 of BZ#1789479] UI changes for UCI: disable CPU throttling, accept TLS certificates for both RHV and OSP conv hosts)
@simaishi
Copy link
Contributor

Backported to ivanchuk via #1113

@simaishi simaishi removed the jansa/yes label May 1, 2020
simaishi added a commit to simaishi/manageiq-v2v that referenced this pull request May 13, 2020
@simaishi
Revert "Merge pull request ManageIQ#1099 from mturley/ui-changes-for-…
71f3a3d 
…uci-2"

This reverts commit c74f1b3, reversing
changes made to b25cd7e.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mzazrivec mzazrivec mzazrivec approved these changes

Assignees

@mzazrivec mzazrivec

Labels
bz Issues filed by QE or having a BZ enhancement ivanchuk/yes? UI Issues and PRs related only to the UI v1.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mturley @miq-bot @simaishi @mzazrivec @Fryguy