Last week in ManageIQ 2016-09-05 #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himdel
changed the title
|
@Fryguy @chrisarcand @imtayadeway @jntullo @chessbyte can you review Martin's blog submission so we can merge this in today. Thanks! |
| [Tim Wade](https://github.com/imtayadeway) has done an impressive amount of work refactoring our REST API code, [converting collections to individual controllers](https://github.com/ManageIQ/manageiq/pull/10890), [moving the entrypoint to ApiController](https://github.com/ManageIQ/manageiq/pull/10880), [changing the namespace](https://github.com/ManageIQ/manageiq/pull/10823) and [removing custom routing](https://github.com/ManageIQ/manageiq/pull/10993), which may make it much easier to expand the API to manage *all* the things, REST style :). | ||
|
|
||
| ### [Add missing gettext](https://github.com/ManageIQ/manageiq/pull/10935) | ||
| [Milan Zazrivec](https://github.com/mzazrivec) is pushing forward with our i18n efforts, this week by adding missign gettext, *and* [restoring internationalization functionality in toolbars](https://github.com/ManageIQ/manageiq/pull/10787). If you want him to keep his sanity, please go through our [i18n guidelines](https://github.com/ManageIQ/guides/blob/master/i18n.md) at least once a week, before bedtime. |
|
If there are no further suggestions, @himdel are all edits complete? |
|
@chessbyte @Fryguy I'd say we can merge this for today's blog entry. Thanks @himdel |
|
I know of no unresolved issues.. for now :) 🙇 |
|
LGTM, nice work @himdel |
|
@himdel 🍰 ✨ 🎈 great issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our newest last week 09/05 - API refactor, Observables and more..