Fix container scanning timeout handling. #10396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moolitayer
force-pushed
the
fix_scan_timeout
branch
3 times, most recently
from
5b57000
to
7ba597c
Compare
|
@moolitayer Cannot apply the following label because they are not recognized: smart_state |
|
👍 |
|
Looks good to me. |
|
@simon3z PTAL |
moolitayer
force-pushed
the
fix_scan_timeout
branch
from
7ba597c
to
eb909a9
Compare
|
@miq-bot add_label darga/yes |
|
@miq-bot assign roliveri LGMT 👍 ready for merge cc @chessbyte |
|
@moolitayer @simon3z Where are the spec/test changes to accompany the code? |
Eliminates failing container scanning jobs that remain in active states. Removes multiple occurrences of[1] seen in logs. In other cases the timeout code would work because a vm with an id that matches that of the target container happen to exist. Using find_by should also handle cases where the target entity no longer exist. This is very common for container entities and should also benefit vms. Bug-url: https://bugzilla.redhat.com/show_bug.cgi?id=1366598 [1] ERROR -- : MIQ(Job.check_jobs_for_timeout) Couldn't find VmOrTemplate with 'id'=3
moolitayer
force-pushed
the
fix_scan_timeout
branch
from
eb909a9
to
f558c50
Compare
|
Checked commit moolitayer@f558c50 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@chessbyte PTAL I've added unit tests and a test for the case of a scan job for a deleted vm. |
This was referenced Aug 19, 2016
chessbyte
pushed a commit
that referenced
this pull request
Aug 23, 2016
Fix container scanning timeout handling. (cherry picked from commit 1a367ea)
|
Darga backport details: |
This was referenced Sep 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates failing container scanning jobs that remain in active states.
Removes multiple occurrences of[1] seen in logs.
In other cases the timeout code would work because
a vm with an id that matches that of the target container
happen to exist.
Using find_by should also handle cases where the
target entity no longer exist. This is very common
for container entities and should also benefit vms.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1366598
[1] ERROR -- : MIQ(Job.check_jobs_for_timeout) Couldn't find VmOrTemplate
with 'id'=3