Support container/infra/cloud provider policies in the UI #11002

alongoldboim · 2016-09-04T14:05:23Z

Enable provider policies definitions.
Control panel ( added option for providers policies )

Control panel Add Policy

Providers panel ( added policies actions )

miq-bot · 2016-09-06T11:41:25Z

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

alongoldboim · 2016-09-13T10:37:39Z

@cben @simon3z @enoodle please have a look.

Fryguy · 2016-09-19T15:48:11Z

app/models/ext_management_system.rb

@@ -27,6 +27,9 @@ def self.supported_types_and_descriptions_hash

  belongs_to :provider
  belongs_to :tenant
+  include ComplianceMixin
+  include CustomAttributeMixin
+  after_initialize :load_custom_attributes


This scares me. after_initialize is a harsh penalty. Also, this will be called for each individual EMS even if you don't need it.

@alongoldboim you probably want to move this functionality down to the container manager. If we need to expose this type of relationship for all managers, we can look at that later.

Also, miq_report, another class that uses load_custom_attributes_for via the CustomAttributeMixin, uses lazy loading to pull in the custom attributes only when they're accessed.

If there's definitely not a way to do this lazily, then at least having it isolated in the container manager would be better than exposing in ext_management_system.

@alongoldboim you probably want to move this functionality down to the container manager. If we need to expose this type of relationship for all managers, we can look at that later.

@alongoldboim @blomquisg idea was to bring this functionality to all type of providers. If this changed then it needs to be properly advertised to everyone (it's very important that it is going to be clear).

in this PR(#11369 ) is loading of virtual custom attributes moved to constructor MiqExpression, @alongoldboim is it enough for your case ?

@Fryguy the idea is to use lazy loading as @lpichler suggested, just need to make sure it works for me in all the cases.
@blomquisg I think we should enable policies for all kinds of providers, do you see a reason why not to do it?
@lpichler going over that patch, will try it later on today, thanks for the help.

@lpichler seems to work well 👍

@alongoldboim so this #11369 needs to be merged first ?

Yep, added a depends on comment.

alongoldboim · 2016-09-20T12:56:06Z

@miq-bot remove_label wip

alongoldboim · 2016-09-20T13:04:04Z

depends on: #11369

alongoldboim · 2016-09-20T14:32:22Z

@Fryguy Looks OK now?

alongoldboim · 2016-11-21T14:55:33Z

@h-kataria any idea why the tests are failing?

alongoldboim · 2016-11-21T18:20:11Z

@h-kataria tests are passing, anything else is missing? :)

h-kataria · 2016-11-21T18:47:36Z

app/controllers/ems_common.rb

+    end
+    process_emss(emss, "check_compliance")
+    showlist ? show_list : show
+    emss.count


@alongoldboim why do we need emss.count here, i don't see that being used.

h-kataria · 2016-11-21T18:48:52Z

app/controllers/ems_common.rb

+                                                               :task  => "Compliance Check"}, :error)
+    end
+    process_emss(emss, "check_compliance")
+    showlist ? show_list : show


@alongoldboim dont need to set showlist variable as it is not being used anywhere else, you could just do

@lastaction == "show_list" ? show_list : show

alongoldboim · 2016-11-22T15:21:41Z

@h-kataria fixed.

miq-bot · 2016-11-22T15:27:28Z

Checked commits alongoldboim/manageiq@d25120a~...a40ee2b with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
17 files checked, 3 offenses detected

app/controllers/application_controller/tree_support.rb

❕ - Line 27, Col 121 - Metrics/LineLength - Line is too long. [130/120]

app/controllers/ems_common.rb

❗ - Line 586, Col 64 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

app/controllers/miq_policy_controller.rb

❕ - Line 16, Col 121 - Metrics/LineLength - Line is too long. [121/120]

h-kataria · 2016-11-22T17:15:42Z

looks good now.

cben · 2016-11-22T22:30:42Z

@alongoldboim compliance events need icons:

simaishi · 2017-01-06T18:22:07Z

@alongoldboim is there a BZ for this?

cben · 2017-01-08T12:20:42Z

Alon left the team. The feature was motivated by "CM-Ops" effort, probably doesn't have a BZ. @simon3z?

The missing icons I mention above also don't have BZ. And while I look at it, shouldn't say "ExtManagementSystem". => ManageIQ/manageiq-ui-classic#94, #13388.

simaishi · 2017-01-09T14:17:22Z

Created BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1411337

Support container/infra/cloud provider policies in the UI (cherry picked from commit 6434490) https://bugzilla.redhat.com/show_bug.cgi?id=1411364

simaishi · 2017-01-09T14:54:14Z

Euwe backport details:

$ git log -1
commit 11bace9720205ed40505c9c4c510259bf1534fc4
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Tue Nov 22 12:15:50 2016 -0500

    Merge pull request #11002 from alongoldboim/enable_proider_policies
    
    Support container/infra/cloud provider policies in the UI
    (cherry picked from commit 6434490304856b340a5628e4fade95b1848e77f6)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1411364

alongoldboim force-pushed the enable_proider_policies branch 2 times, most recently from 63f007f to 162b83e Compare September 5, 2016 13:04

chessbyte added the wip label Sep 5, 2016

alongoldboim force-pushed the enable_proider_policies branch 3 times, most recently from 023cb47 to d503ffe Compare September 6, 2016 11:38

alongoldboim force-pushed the enable_proider_policies branch 11 times, most recently from baa9333 to f999f1a Compare September 8, 2016 14:30

alongoldboim closed this Sep 12, 2016

alongoldboim reopened this Sep 12, 2016

Fryguy reviewed Sep 19, 2016

View reviewed changes

alongoldboim force-pushed the enable_proider_policies branch 3 times, most recently from 8f4240a to fe03957 Compare September 20, 2016 12:51

alongoldboim changed the title ~~[WIP] Support provider policies~~ Support provider policies Sep 20, 2016

miq-bot removed the wip label Sep 20, 2016

dclarizio assigned h-kataria Nov 18, 2016

alongoldboim force-pushed the enable_proider_policies branch from b4016c5 to 149e304 Compare November 20, 2016 12:10

alongoldboim closed this Nov 21, 2016

alongoldboim reopened this Nov 21, 2016

alongoldboim closed this Nov 21, 2016

alongoldboim reopened this Nov 21, 2016

Support provider policies

d25120a

alongoldboim force-pushed the enable_proider_policies branch from 149e304 to 76154da Compare November 21, 2016 15:10

h-kataria reviewed Nov 21, 2016

View reviewed changes

use process emss

a40ee2b

alongoldboim force-pushed the enable_proider_policies branch from 76154da to a40ee2b Compare November 22, 2016 15:21

h-kataria added this to the Sprint 50 Ending Dec 5, 2016 milestone Nov 22, 2016

h-kataria merged commit 6434490 into ManageIQ:master Nov 22, 2016

cben mentioned this pull request Nov 22, 2016

Add missing "Provider Compliance/Control Policies" texts #12803

Merged

cben mentioned this pull request Jan 8, 2017

Rename events "ExtManagementSystem Compliance *" -> "Provider Compliance *" #13388

Merged

cben mentioned this pull request Jan 8, 2017

Add missing icons for provider policies & compliance events ManageIQ/manageiq-ui-classic#94

Merged

simaishi added euwe/backported and removed euwe/yes labels Jan 9, 2017

cben mentioned this pull request Jan 16, 2017

[EUWE] Add missing icons for provider policies & compliance events #13502

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support container/infra/cloud provider policies in the UI #11002

Support container/infra/cloud provider policies in the UI #11002

alongoldboim commented Sep 4, 2016 •

edited

Loading

miq-bot commented Sep 6, 2016

alongoldboim commented Sep 13, 2016

Fryguy Sep 19, 2016

blomquisg Sep 19, 2016

simon3z Sep 19, 2016

lpichler Sep 20, 2016 •

edited

Loading

alongoldboim Sep 20, 2016

alongoldboim Sep 20, 2016

lpichler Sep 20, 2016

alongoldboim Sep 20, 2016

alongoldboim commented Sep 20, 2016

alongoldboim commented Sep 20, 2016

alongoldboim commented Sep 20, 2016

alongoldboim commented Nov 21, 2016

alongoldboim commented Nov 21, 2016

h-kataria Nov 21, 2016

h-kataria Nov 21, 2016

alongoldboim commented Nov 22, 2016

miq-bot commented Nov 22, 2016

h-kataria commented Nov 22, 2016

cben commented Nov 22, 2016

simaishi commented Jan 6, 2017

cben commented Jan 8, 2017

simaishi commented Jan 9, 2017

simaishi commented Jan 9, 2017

Support container/infra/cloud provider policies in the UI #11002

Support container/infra/cloud provider policies in the UI #11002

Conversation

alongoldboim commented Sep 4, 2016 • edited Loading

miq-bot commented Sep 6, 2016

alongoldboim commented Sep 13, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lpichler Sep 20, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alongoldboim commented Sep 20, 2016

alongoldboim commented Sep 20, 2016

alongoldboim commented Sep 20, 2016

alongoldboim commented Nov 21, 2016

alongoldboim commented Nov 21, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alongoldboim commented Nov 22, 2016

miq-bot commented Nov 22, 2016

h-kataria commented Nov 22, 2016

cben commented Nov 22, 2016

simaishi commented Jan 6, 2017

cben commented Jan 8, 2017

simaishi commented Jan 9, 2017

simaishi commented Jan 9, 2017

alongoldboim commented Sep 4, 2016 •

edited

Loading

lpichler Sep 20, 2016 •

edited

Loading