Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No reset button for Job Template Service Dialog #11830

Merged
merged 2 commits into from
Oct 12, 2016

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Oct 11, 2016

The Tower Job Template Service Dialog should not have a Reset button - as the form is always creating a new dialog, not editing an existing one

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1382618

Steps for #Testing

Steps to Reproduce:

  1. Add Tower provider, perform refresh and navigate to Ansible Tower Job templates
  2. Click on any template and 'Create Service dialog from the template

Before

screenshot from 2016-10-11 17-48-23

After:
screenshot from 2016-10-11 17-45-20

@lgalis
Copy link
Contributor Author

lgalis commented Oct 11, 2016

@miq-bot add_label ui, bug, wip

@lgalis lgalis force-pushed the tower_job_custom_dialog_reset_fail branch from f648cd5 to 749c7ec Compare October 11, 2016 21:42
@lgalis lgalis changed the title [WIP] No reset button for Job Template Service Dialog No reset button for Job Template Service Dialog Oct 11, 2016
@lgalis
Copy link
Contributor Author

lgalis commented Oct 11, 2016

@miq-bot remove_label wip

@lgalis
Copy link
Contributor Author

lgalis commented Oct 11, 2016

/cc @dclarizio

@miq-bot miq-bot removed the wip label Oct 11, 2016
@mzazrivec mzazrivec added this to the Sprint 48 Ending Oct 24, 2016 milestone Oct 12, 2016
@mzazrivec mzazrivec self-assigned this Oct 12, 2016
@mzazrivec mzazrivec merged commit cfa001a into ManageIQ:master Oct 12, 2016
chessbyte pushed a commit that referenced this pull request Oct 13, 2016
@chessbyte
Copy link
Member

Euwe Backport details:

$ git log
commit 41b4166c05cc92a3c82c25fb831aa61ded15d281
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Wed Oct 12 11:00:07 2016 +0200

    Merge pull request #11830 from lgalis/tower_job_custom_dialog_reset_fail

    No reset button for Job Template Service Dialog
    (cherry picked from commit cfa001acb5f2965347f3c4f6b28c364b77581f08)

    https://bugzilla.redhat.com/show_bug.cgi?id=1382618

@lgalis lgalis deleted the tower_job_custom_dialog_reset_fail branch October 21, 2016 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants