Change 'Images' to 'ContainerImages' under chargeback rate assignments #13198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzazrivec
suggested changes
Dec 16, 2016
| "container_image-tags" => PostponedTranslation.new(N_("Tagged %{tables}")) do | ||
| {:tables => ui_lookup(:tables => "container_image")} | ||
| "container_image-tags" => PostponedTranslation.new(N_("Tagged %{models}")) do | ||
| {:models => ui_lookup(:models => "container_image")} |
There was a problem hiding this comment.
There's no such model called container_image, nor is it present in locale/en.yml under model. What you
probably meant to use here was ui_lookup(:models => "ContainerImage").
| "container_image-labels" => PostponedTranslation.new(N_("Labeled %{tables}")) do | ||
| {:tables => ui_lookup(:tables => "container_image")} | ||
| "container_image-labels" => PostponedTranslation.new(N_("Labeled %{models}")) do | ||
| {:models => ui_lookup(:models => "container_image")} |
zeari
force-pushed
the
cb_rate_assign_container
branch
from
781efde
to
1a62689
Compare
|
Thanks @mzazrivec ! |
zeari
force-pushed
the
cb_rate_assign_container
branch
from
1a62689
to
598287e
Compare
|
Checked commit zeari@598287e with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
mzazrivec
approved these changes
Dec 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@simon3z
@miq-bot add_label ui, chargeback, providers/containers