[EUWE] Improve rbac tree spec #14445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yay, net deletion too! ✂️ 🔥 ✂️ 🔥 ✂️ 🔥 🍰 🍪 👏 🙇 😍 🎉 |
Fryguy
approved these changes
Mar 22, 2017
|
These changes look good. |
jrafanie
approved these changes
Mar 27, 2017
hayesr
force-pushed
the
improve_rbac_tree_spec
branch
from
8bca7dd
to
b0be338
Compare
|
Travis, y u no green? |
hayesr
force-pushed
the
improve_rbac_tree_spec
branch
from
f3b7141
to
4277026
Compare
|
Checked commits hayesr/manageiq@9b4dad1~...4277026 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change minimizes the features loaded before each example in this spec. Follow-up to #14431
/cc @kbrock @jrafanie @Fryguy