Load custom attribute before evaluation #14785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading virtual custom attributes is not needed in constructor we need to load them when we need them and this place is in Condition#_subst method where Tag.list is called In addition, constructor is not called when MiqExpressin is loaded from yaml (for example as it is in used MiqReport#condition for generation reports)
this feature is need to test it in RBAC - filterer
In add_custom_attribute is also checking whether attribute has been already loaded
lpichler
force-pushed
the
load_custom_attribute_before_evaluation
branch
from
342841e
to
f4d298e
Compare
|
Checked commits lpichler/manageiq@549e80c~...f4d298e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot add_label fine/yes |
simaishi
pushed a commit
that referenced
this pull request
Apr 20, 2017
…evaluation Load custom attribute before evaluation (cherry picked from commit 291b266)
|
Fine backport details: |
|
@lpichler Need a BZ for Euwe backport... |
|
@lpichler ping ^ |
|
@simaishi Libor created https://bugzilla.redhat.com/show_bug.cgi?id=1459171 and I added it to the description. Thanks. |
|
@lpichler |
|
Backported to Euwe via #15320 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduced in #11369
Loading virtual custom attributes is not needed in constructor
we need to load them when we need them and this place is in
Condition#_substmethod whereTag.listis calledIn addition, constructor is not called when MiqExpressin is loaded from yaml (for example as it is in used MiqReport#condition for generation reports)
This is fixing a bug when report has defined expression with virtual custom attribute and these attributes are not listed in Report#cols
@miq-bot add_label bug, core
@miq-bot assign @gtanzillo
https://bugzilla.redhat.com/show_bug.cgi?id=1459171