Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a precanned physical server policy #17624

Merged
merged 2 commits into from
Jun 26, 2018

Conversation

skovic
Copy link

@skovic skovic commented Jun 21, 2018

This PR adds a precanned policy and profile for powering on servers that were powered off.

@miq-bot
Copy link
Member

miq-bot commented Jun 21, 2018

Checked commits skovic/manageiq@8ac85c8~...c77720b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@skovic
Copy link
Author

skovic commented Jun 22, 2018

@miq-bot remove_label wip

@miq-bot miq-bot changed the title [WIP] Add a precanned physical server policy Add a precanned physical server policy Jun 22, 2018
@miq-bot miq-bot removed the wip label Jun 22, 2018
@skovic
Copy link
Author

skovic commented Jun 22, 2018

@agrare Could you take a look at this PR when you get a chance? Thanks

@gmcculloug
Copy link
Member

@skovic Just curious, do you think there will be a corresponding power_off action for PhysicalServers in the future?

@agrare Anything to add here?

@skovic
Copy link
Author

skovic commented Jun 26, 2018

@gmcculloug It is possible that it may be added in the future, but that can be done in another PR. We just wanted to get a precanned policy in so that users can use it as an example to create their own.

@agrare
Copy link
Member

agrare commented Jun 26, 2018

@gmcculloug this looks fine to me

@gmcculloug gmcculloug merged commit 2bd1fed into ManageIQ:master Jun 26, 2018
@gmcculloug gmcculloug added this to the Sprint 89 Ending Jul 2, 2018 milestone Jun 26, 2018
@gmcculloug
Copy link
Member

@skovic Merging now but still curious if you see other actions that will be created for physical servers in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants