remove fog deprecation warnings #33

kbrock · 2014-06-16T19:44:24Z

Use latest version of the gem.

This removes warnings:

[fog][DEPRECATION] #connection= is deprecated, pass :service in at creation (lib/fog/openstack/models/compute/server.rb:187:in `block in security_groups')

Not sure the proper testing of this gem.

miq-bot · 2014-06-16T19:50:49Z

@ManageIQ/core-build Gemfile changes detected in commit kbrock@13761ac. Please review.

miq-bot · 2014-06-26T18:36:46Z

This pull request is not mergeable. Please rebase and repush.

miq-bot · 2014-07-01T13:01:07Z

@ManageIQ/core-build Gemfile changes detected in commit kbrock@1cc6f48. Please review.

kbrock · 2014-07-01T14:47:59Z

~~/cc @brandondunne do you know if the patch we made is on there?~~ blomquisg and I verified it is in there

/cc @blomquisg any other concerns from your side?
/cc @JPrause what steps do I need to do to get the gem into the official channel?

kbrock · 2014-07-01T14:48:49Z

/cc @Fryguy do you have a reason for pinning the correct version of the aws gem?

blomquisg · 2014-07-01T14:56:29Z

@kbrock, ack on the Fog version change (and, consequently, the excon version change).

https://github.com/fog/fog/blame/v1.22.0/lib/fog/openstack/models/network/security_groups.rb

That shows that @brandondunne's changes are available in the 1.22.0 tag of Fog. Looks good to me.

bdunne · 2014-07-01T15:02:11Z

@kbrock My changes were merged. We only forked the gem because of a downstream release where we didn't want everything that was required by v1.20. I don't think there is anything holding us back from upgrading on master.

JPrause · 2014-07-01T15:06:15Z

@kbrock
Is this an updated version of fog gem? If so, what's the version,..v1.22.0?
I can create the rpm of the gem,..and have to go through my notes on how it gets tagged for a particular CFME build.

kbrock · 2014-07-01T15:37:24Z

@JPrause

On my mac I bundled ; made the update ; and bundled again, diff'd Gemfile.lock in lib and vmdb
Hope that is the right process.

Here are the changes:

excon (0.32.1)
fog (1.22.0)
fog-brightbox (0.0.2)
fog-core (1.21.1)
fog-json (1.0.0)
aws-sdk (1.41.0)

No longer using ruby-hmac - not sure if you care
Should I put this into a PR?

bdunne · 2014-07-01T18:58:45Z

@kbrock As long as we're keeping the Gemfile.lock, it should be updated with those changes. https://github.com/ManageIQ/manageiq/blob/master/vmdb/lockfiles/RHEL6.4/Gemfile.lock

bdunne · 2014-07-01T21:18:31Z

No comment from @jrafanie about upgrading the aws gem in a PR about getting rid of Fog deprecation warnings?

jrafanie · 2014-07-03T15:50:28Z

@kbrock @Fryguy so yeah, @brandondunne is right, what's the deal with aws-sdk? Is this related to the deprecation warnings from Fog? I don't use fog, excon(needed by VCR if I recall) or aws-sdk so I'm not sure who can verify it's ok to merge this.

Fryguy · 2014-07-03T15:52:23Z

@kbrock I want to get this in, but I think I would like Travis to run against it. Can you rebase against master and repush?

miq-bot · 2014-07-03T16:21:05Z

@ManageIQ/core-build Gemfile changes detected in commit kbrock@4662a32. Please review.

chessbyte · 2014-07-03T17:32:38Z

@Fryguy @kbrock @jrafanie Travis found gem conflicts

  In Gemfile:
    rubywbem (= 0.1.0) ruby depends on
      nokogiri (~> 1.5.0) ruby

    fog (~> 1.22.0) ruby depends on
      nokogiri (1.6.2.1)

kbrock · 2014-07-03T17:35:45Z

Yay. who's great idea was it to install travis?

jrafanie · 2014-07-03T20:29:36Z

@kbrock @chessbyte seems like a bug in bundler 1.3.5.

I can bundle using my existing lock file on this PR branch and it's fine.

If I try bundle update nokogiri, bundler is choosing nokogiri 1.6.2.1 instead of 1.5.11 which satisfies all dependencies. It chose that because it chose to try to "activate" fog before rubywbem.

From:
DEBUG_RESOLVER=y bundle update nokogiri

Attempting:
nokogiri (>= 1.5.11, > 1.5) ruby
Activating: nokogiri (1.6.2.1)
* fog (> 1.22.0)
* nokogiri (>= 1.5.11, ~> 1.5)
Dependencies
* mini_portile (= 0.6.0)

Choices? Hardcode nokogiri 1.5.11 in our Gemfile to make it easier on bundler.

It works if I put ~> 1.5.11 and try it again.

jrafanie · 2014-07-03T21:27:19Z

@kbrock But of course, we'll need to package up nokogiri.

kbrock · 2014-07-04T03:45:50Z

@jrafanie thanks for the research.

It is very clear that rubywbem wants ~>1.5.0, which is will not wnt to upgrade to 1.6.2.1.

So I'm thinking this is a conflict and shouldn't work. I also think that the code will work if we update the dependency in the rubywbem.gemspec. Need to test this out of course.

Huh, looks like bundler is up to 1.6.3!

chessbyte · 2014-07-07T17:34:53Z

Since Travis is now green, please rebase to ensure that this PR continues to keep our tests passing.

miq-bot · 2014-07-08T14:30:55Z

@ManageIQ/core-build Gemfile changes detected in commit kbrock@6b0ce37. Please review.

kbrock · 2014-07-08T14:31:33Z

@chessbyte I pushed again. but I am pretty sure this conflicts with rubywbem. And it should due to the dependencies stated in that gem. we are using ~>1.5.0.

Now I don't think that gem should be stating the exact dependencies, so will look into that after I get the CA stuff done

kbrock · 2014-07-10T21:13:56Z

Huh, it passed...

Thanks @jrafanie / @chessbyte I totally misunderstood your comments.

miq-bot · 2014-07-25T15:06:06Z

@ManageIQ/core-build Gemfile changes detected in commit kbrock@d2259ac. Please review.

miq-bot · 2014-07-25T18:46:03Z

@ManageIQ/core-build Gemfile changes detected in commit kbrock@d5f2572. Please review.

kbrock · 2014-08-01T02:15:16Z

rebased and pushed to keep it up to date. ?

miq-bot · 2014-08-01T02:15:54Z

@ManageIQ/core-build Gemfile changes detected in commit kbrock@fc23067. Please review.

miq-bot · 2014-08-01T02:25:50Z

@ManageIQ/core-build Gemfile changes detected in commit kbrock@4da45ed. Please review.

miq-bot · 2014-08-07T22:21:11Z

@ManageIQ/core-build Gemfile changes detected in commit kbrock@1510da9. Please review.

miq-bot · 2014-08-08T15:21:18Z

@ManageIQ/core-build Gemfile changes detected in commit kbrock@4816a89. Please review.

kbrock · 2014-10-21T17:25:17Z

@Fryguy pegging the Gemfile to match the built rpms is a great idea

Use latest version of the gem [fog][DEPRECATION] #connection= is deprecated, pass :service in at creation (lib/fog/openstack/models/compute/server.rb:187:in `block in security_groups')

miq-bot · 2014-10-21T17:31:25Z

@ManageIQ/core-build Gemfile changes detected in commit kbrock@8cbaf64. Please review.

miq-bot · 2014-10-21T17:32:29Z

Checked commits kbrock@8cbaf64 .. kbrock@6bafdf5 with rubocop 0.21.0
1 file checked, 0 offenses detected
Everything looks good. ⭐

Fryguy · 2014-10-21T21:32:45Z

@jvlcek @JPrause You ok with this now?

Fryguy · 2014-10-31T14:55:52Z

BUMP @jvlcek @JPrause

jrafanie · 2014-10-31T16:22:14Z

To clarify, this is for NEW development, not intended for backports, right?

jvlcek · 2014-10-31T19:20:12Z

This change requires adding new gems and some of them need new gems... @JPrause is making up the list and we will review. But if this is for NEW development I am sure we will get them brewed in time.

Fryguy · 2014-10-31T19:34:11Z

Yes, should only be new stuff.

Pulling in stuff that has already been upstreamed.
Allowing @bzwei to add any Orchestration code to fog tip.

kbrock · 2014-11-01T22:16:57Z

@Fryguy Trying to understand implications of your last comment. I wanted to @JPrause to point to rubygem version of gems. When @bzwei adds features, it will take a while to get into rubygems. So we'll probably point back at our version. ok with you?

JPrause · 2014-11-02T22:52:07Z

@kbrock @Fryguy @jvlcek Me and JoeV spoke about the newer versions of fog and excon.
As well as their dependancies,...
I started an etherpad to try and track these gem dependancies,...but how deep do we go????
Take a look http://cloudforms-eng.etherpad.corp.redhat.com/23

jvlcek · 2014-11-03T15:38:41Z

@JPrause We need to identify "all" sub-dependancies, then check what we have already brewed. Let's work on it together.

kbrock · 2014-11-03T17:24:49Z

@JPrause @jvlcek I tried to do that research for you. You can find those results in the RHEL lock file changes.

JPrause · 2014-11-03T17:27:36Z

@kbrock @jvlcek @Fryguy Thanks,...Keenan. Jason walked me through how to evaluate/diff Gemfile for the new depandancis. and I'll be documenting the process.

kbrock · 2014-11-05T15:39:06Z

Thanks @JPrause you ok to merge this one. It has a lot of gems in here.

JPrause · 2014-11-05T15:46:49Z

@kbrock Yes,...feel free to merge away.

bdunne · 2014-11-05T16:01:30Z

@kbrock Looks Good 👍

jrafanie · 2014-11-05T17:35:02Z

It feels good to get this one done... good work everyone ;-)

remove fog deprecation warnings

…s-vm Provision VM-attached volumes in the same tenant as the VM (cherry picked from commit 1c4ed0b530268a9964b846a4e60a862d2b55a510) https://bugzilla.redhat.com/show_bug.cgi?id=1450220

…s-vm Provision VM-attached volumes in the same tenant as the VM (cherry picked from commit 1c4ed0b530268a9964b846a4e60a862d2b55a510) https://bugzilla.redhat.com/show_bug.cgi?id=1450525

Fix host targeted refresh in v4 (cherry picked from commit aa17fe0a18bac7a7801026e898fe428034b6ab1e) https://bugzilla.redhat.com/show_bug.cgi?id=1458951

Warn if no hardware (cherry picked from commit bb7e574826d48e5cc34b0ff112a584ad17dde5b9) https://bugzilla.redhat.com/show_bug.cgi?id=1461522

fix builds namespace matching (cherry picked from commit b5f96e01870748070b2cd730693dc3c0ffae17dd) https://bugzilla.redhat.com/show_bug.cgi?id=1478558

…hing fix builds namespace matching (cherry picked from commit b5f96e01870748070b2cd730693dc3c0ffae17dd) https://bugzilla.redhat.com/show_bug.cgi?id=1478558

kbrock added 2 commits October 21, 2014 13:29

remove fog deprecation warnings

8cbaf64

Use latest version of the gem [fog][DEPRECATION] #connection= is deprecated, pass :service in at creation (lib/fog/openstack/models/compute/server.rb:187:in `block in security_groups')

update RHEL6.4 Gemfile.lock for fog fog

6bafdf5

kbrock force-pushed the gem_fog branch from 4846a48 to 6bafdf5 Compare October 21, 2014 17:29

jrafanie added a commit that referenced this pull request Nov 5, 2014

Merge pull request #33 from kbrock/gem_fog

8828ee8

remove fog deprecation warnings

jrafanie merged commit 8828ee8 into ManageIQ:master Nov 5, 2014

kbrock deleted the gem_fog branch November 5, 2014 18:09

Fryguy added this to the Sprint 15 - Nov 11, 2014 milestone Nov 5, 2014

simaishi pushed a commit that referenced this pull request Jun 14, 2017

Merge pull request #33 from yaacov/warn-if-no-hardwar

b778635

Warn if no hardware (cherry picked from commit bb7e574826d48e5cc34b0ff112a584ad17dde5b9) https://bugzilla.redhat.com/show_bug.cgi?id=1461522

remove fog deprecation warnings #33

remove fog deprecation warnings #33

Conversation

kbrock commented Jun 16, 2014

miq-bot commented Jun 16, 2014

miq-bot commented Jun 26, 2014

miq-bot commented Jul 1, 2014

kbrock commented Jul 1, 2014

kbrock commented Jul 1, 2014

blomquisg commented Jul 1, 2014

bdunne commented Jul 1, 2014

JPrause commented Jul 1, 2014

kbrock commented Jul 1, 2014

bdunne commented Jul 1, 2014

bdunne commented Jul 1, 2014

jrafanie commented Jul 3, 2014

Fryguy commented Jul 3, 2014

miq-bot commented Jul 3, 2014

chessbyte commented Jul 3, 2014

kbrock commented Jul 3, 2014

jrafanie commented Jul 3, 2014

jrafanie commented Jul 3, 2014

kbrock commented Jul 4, 2014

chessbyte commented Jul 7, 2014

miq-bot commented Jul 8, 2014

kbrock commented Jul 8, 2014

kbrock commented Jul 10, 2014

miq-bot commented Jul 25, 2014

miq-bot commented Jul 25, 2014

kbrock commented Aug 1, 2014

miq-bot commented Aug 1, 2014

miq-bot commented Aug 1, 2014

miq-bot commented Aug 7, 2014

miq-bot commented Aug 8, 2014

kbrock commented Oct 21, 2014

miq-bot commented Oct 21, 2014

miq-bot commented Oct 21, 2014

Fryguy commented Oct 21, 2014

Fryguy commented Oct 31, 2014

jrafanie commented Oct 31, 2014

jvlcek commented Oct 31, 2014

Fryguy commented Oct 31, 2014

kbrock commented Nov 1, 2014

JPrause commented Nov 2, 2014

jvlcek commented Nov 3, 2014

kbrock commented Nov 3, 2014

JPrause commented Nov 3, 2014

kbrock commented Nov 5, 2014

JPrause commented Nov 5, 2014

bdunne commented Nov 5, 2014

jrafanie commented Nov 5, 2014