Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert style1 class tables to Patternfly #2 #3324

Merged
merged 1 commit into from
Jul 6, 2015
Merged

Convert style1 class tables to Patternfly #2 #3324

merged 1 commit into from
Jul 6, 2015

Conversation

epwinchell
Copy link
Contributor

Issue: #3139

Old:
screen shot 2015-07-01 at 10 57 27 am
New:
screen shot 2015-07-01 at 11 10 22 am

@epwinchell epwinchell changed the title [WIP] Convert style1 class tables to Patternfly (Control) [WIP] Convert style1 class tables to Patternfly #2 Jul 1, 2015
@epwinchell epwinchell changed the title [WIP] Convert style1 class tables to Patternfly #2 Convert style1 class tables to Patternfly #2 Jul 2, 2015
@epwinchell
Copy link
Contributor Author

@dclarizio please review

@miq-bot
Copy link
Member

miq-bot commented Jul 2, 2015

Checked commit https://github.com/epwinchell/manageiq/commit/b057c5024567038d038ddd4a6c4c89406e99c44d with rubocop 0.32.0
7 files checked, 4 offenses detected

vmdb/app/views/miq_policy/_policy_details.html.haml

  • 🔴 Warn - Line 39, Col - - Line is too long. [143/120]
  • 🔴 Warn - Line 39, Col - - Style/FormatString: Favor format over String#%.
  • 🔴 Warn - Line 46, Col - - Line is too long. [145/120]
  • 🔴 Warn - Line 46, Col - - Style/FormatString: Favor format over String#%.

@Fryguy
Copy link
Member

Fryguy commented Jul 6, 2015

@dclarizio Did you have reservations on merging?

dclarizio pushed a commit that referenced this pull request Jul 6, 2015
Merge pull request #3324 from epwinchell/style1_tables_to_patternfly3
e746b05 
Convert style1 class tables to Patternfly #2
@dclarizio dclarizio merged commit e746b05 into ManageIQ:master Jul 6, 2015
@dclarizio dclarizio deleted the style1_tables_to_patternfly3 branch July 6, 2015 20:07
@dclarizio dclarizio added this to the Sprint 26 Ending July 13, 2015 milestone Jul 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@epwinchell @miq-bot @Fryguy @dclarizio