GCE ecdsa ssh keys #6482
Merged
GCE ecdsa ssh keys #6482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add-label bug, providers/google |
|
@agrare Thanks! It works well for me. 👍 |
|
ping @blomquisg |
| :fingerprint => fingerprint | ||
| } | ||
| rescue => err | ||
| _log.warn { err.backtrace.join('\n') } |
There was a problem hiding this comment.
Do you want to log a message with it as well?
agrare
force-pushed
the
gce_ecdsa_ssh_keys
branch
from
cde2085
to
53a793e
Compare
|
@blomquisg Please review |
agrare
force-pushed
the
gce_ecdsa_ssh_keys
branch
from
53a793e
to
4f8be1e
Compare
|
Checked commits agrare/manageiq@a612c27~...4f8be1e with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCE sometimes adds ecdsa nist keys that are unsupported by the sshkey gem, this skips over them so inventory refresh can continue.
/cc @enoodle can you confirm this fixes your issue?