DialogUser - update validator_type during field refresh #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when validator_type is set to 'regex' on load, the field will use the current validator_rule to validate, but if validator_type is changed only later in a method, the field never starts to validate. Making sure both validator_rule and validator_type are respected during field refresh. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1769960
eclarizio
suggested changes
Nov 15, 2019
There was a problem hiding this comment.
Think you can add an expectation for the validator_rule and validator_type in https://github.com/ManageIQ/ui-components/blob/master/src/dialog-user/components/dialog-user/dialogUser.spec.ts#L260?
|
cc @tinaafitz |
|
Updated the spec, thanks :) |
|
Checked commits https://github.com/himdel/ui-components/compare/172297da2e91b9643368af568c9aae965e2ce2e6~...ae83007090a25b305ae2a780164d0e2f04abbae8 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Nov 18, 2019
DialogUser - update validator_type during field refresh (cherry picked from commit e142ea3) https://bugzilla.redhat.com/show_bug.cgi?id=1773626
|
Hammer backport details: |
This was referenced Nov 18, 2019
simaishi
pushed a commit
that referenced
this pull request
Dec 16, 2019
DialogUser - update validator_type during field refresh (cherry picked from commit e142ea3) https://bugzilla.redhat.com/show_bug.cgi?id=1773627
|
Ivanchuk backport details: |
This was referenced Jan 6, 2020
This was referenced May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when validator_type is set to 'regex' on load, the field will use the current validator_rule to validate,
but if validator_type is changed only later in a method, the field never starts to validate.
Making sure both validator_rule and validator_type are respected during field refresh.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1769960