RP-1: Styleguide. #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @import "checkbox"; | ||
| @import "lists"; | ||
| @import "radio"; | ||
| @import "typography"; |
There was a problem hiding this comment.
typography should be the first one. It contains base styles that may be overridden in the other sheets.
| margin-left: 10px; | ||
| } | ||
|
|
||
| input[type='submit'].button-red, .button-red, |
There was a problem hiding this comment.
It's hard to add a class to submit buttons. All submits will have the same style. Other colors and button styles will only be used in links (i.e. CTA's).
cienvaras
added
Needs Work
and removed
Waiting Code Review
Waiting Functional Review
labels
…P-1-style-guide-styles
|
@erian7 Add a |
| font-family: $open-sans; | ||
| line-height: 1.4; | ||
| color: $dark; | ||
| font-size: 62.5%; |
There was a problem hiding this comment.
Body font-size would be 62.5% of 62.5%.
EdgarBarrantes
added
Waiting Code Review
Waiting Functional Review
and removed
Needs Work
labels
cienvaras
added
Passes Code Review
Passes Functional Review
Ready to Merge
and removed
Waiting Code Review
Waiting Functional Review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do:
Steps to test: