Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for skipping URL rewrites on certain elements #154

Merged
merged 3 commits into from
Apr 4, 2018

Conversation

Mange
Copy link
Owner

@Mange Mange commented Apr 4, 2018

This PR supersedes #137; it adds extra documentation and integration tests.

Thank you @hasghari for the basis of this feature.

@Mange Mange added the feature label Apr 4, 2018
@codecov-io
Copy link

codecov-io commented Apr 4, 2018

Codecov Report

Merging #154 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   97.92%   97.94%   +0.01%     
==========================================
  Files          57       57              
  Lines        1884     1896      +12     
==========================================
+ Hits         1845     1857      +12     
  Misses         39       39
Impacted Files Coverage Δ
lib/roadie/asset_scanner.rb 100% <ø> (ø) ⬆️
spec/lib/roadie/asset_scanner_spec.rb 100% <ø> (ø) ⬆️
spec/integration_spec.rb 100% <100%> (ø) ⬆️
spec/lib/roadie/url_rewriter_spec.rb 100% <100%> (ø) ⬆️
lib/roadie/document.rb 100% <100%> (ø) ⬆️
spec/lib/roadie/document_spec.rb 100% <100%> (ø) ⬆️
lib/roadie/url_rewriter.rb 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8233590...c53b4e0. Read the comment docs.

@Mange Mange merged commit a2cdaa1 into master Apr 4, 2018
@Mange Mange deleted the roadie-ignore-links branch April 4, 2018 21:01
@hasghari
Copy link

hasghari commented Apr 4, 2018

Awesome, thanks!

@Mange
Copy link
Owner Author

Mange commented Apr 4, 2018

Version 3.3.0 was just released with this included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants