Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix types for various functions #105

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Fix types for various functions #105

merged 2 commits into from
Oct 12, 2023

Conversation

mkashirin
Copy link
Contributor

No description provided.

PhilippImhof
PhilippImhof approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@PhilippImhof PhilippImhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

dkmar
dkmar reviewed Oct 12, 2023
View reviewed changes
manimpango/cmanimpango.pyx Outdated Show resolved Hide resolved
@naveen521kk naveen521kk changed the base branch from main to v0 October 12, 2023 14:09
@naveen521kk
Copy link
Member

The PR should be made to the v0 branch since the main branch contains the v1 release series. I've changed the base branch using Github's UI though looks like there are some conflicts, I'll rebase and update it in a bit.

@naveen521kk naveen521kk changed the title Update cmanimpango.pyx Fix types for various functions Oct 12, 2023
@naveen521kk naveen521kk merged commit 83d5bf6 into ManimCommunity:v0 Oct 12, 2023
19 of 20 checks passed
@naveen521kk naveen521kk mentioned this pull request Oct 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkmar dkmar dkmar left review comments

@PhilippImhof PhilippImhof PhilippImhof approved these changes

@naveen521kk naveen521kk Awaiting requested review from naveen521kk naveen521kk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkashirin @naveen521kk @dkmar @PhilippImhof