-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Ruff for linting + fix linting errors #3774
Conversation
Nice work! However, I don't see myself reviewing this in it's current form. There's way to much in a single PR. Especially because ideally, the formatting changes will be added into the git-blame-ignore-revs file, and this is not possible in its current form as we use squash and merge. I think this could be split into separate PRs, roughly:
[tool.ruff]
line-length = "..."
extend-exclude = ["..."] # Not sure if any extra excludes is required
|
I was thinking of that. My only real thought was that pre-commit ci would try to autofix and create a bigger difference than necessary (as originally, I just wanted one PR for pyproject/pre-commit changes and another PR for the diff). Doesn't hurt to try, I'll see what happens |
Yep, for this, you can add the necessary ruff configuration as I described, and then in a follow up PR make the change in the pre-commit file and let format everything (or let pre-commit do it) |
I'll just use this PR as a tracking PR then. |
See #3622
I'm also a big fan of Ruff, so I went ahead and replaced black and flake8 with it.
Status