Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruff Lint #3780

Merged
merged 19 commits into from
Jun 4, 2024
Merged

Add Ruff Lint #3780

merged 19 commits into from
Jun 4, 2024

Conversation

JasonGrace2282
Copy link
Member

@JasonGrace2282 JasonGrace2282 commented May 22, 2024

Adds ruff linting and replaces isort in pre-commit ci

Only change I'm not sure of is in manim/mobject/opengl/opengl_mobject.py because there are two invert methods defined. I deleted the one without the self.assemble_family, but I'm not sure if that is the correct behavior (it's the current behavior).

Copy link
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry had some pending comments

conftest.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

manim/utils/docbuild/autoaliasattr_directive.py Outdated Show resolved Hide resolved
@Viicos
Copy link
Member

Viicos commented May 31, 2024

Only change I'm not sure of is in manim/mobject/opengl/opengl_mobject.py because there are two invert methods defined. I deleted the one without the self.assemble_family, but I'm not sure if that is the correct behavior (it's the current behavior).

Unfortunate, but let's keep it this way. Keeping the last method was the best path :)

Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
@JasonGrace2282 JasonGrace2282 enabled auto-merge (squash) May 31, 2024 18:20
@JasonGrace2282 JasonGrace2282 merged commit 252aac3 into ManimCommunity:main Jun 4, 2024
17 of 18 checks passed
@JasonGrace2282 JasonGrace2282 deleted the lint-ruff branch June 4, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants