-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruff Lint #3780
Add Ruff Lint #3780
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry had some pending comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Unfortunate, but let's keep it this way. Keeping the last method was the best path :) |
Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
Adds ruff linting and replaces isort in pre-commit ci
Only change I'm not sure of is in
manim/mobject/opengl/opengl_mobject.py
because there are twoinvert
methods defined. I deleted the one without theself.assemble_family
, but I'm not sure if that is the correct behavior (it's the current behavior).