Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Tests & Formatting & Update CI #16

Merged
merged 23 commits into from
May 4, 2023
Merged

Integration Tests & Formatting & Update CI #16

merged 23 commits into from
May 4, 2023

Conversation

furkanmtorun
Copy link
Collaborator

@furkanmtorun furkanmtorun commented Apr 25, 2023 •
edited
Loading

Hi @straussmaximilian , as addressed in #4 ,

  • I played around with selenium and robot-framework for bringing a UI test on streamlit but it turned out very involved so changed the strategy to make integration test to compare the prev. run result.
    I know, the str is not the best way but we can change it later then to dict with arrays expectedly
  • Also updated the CI.
  • For some files, I applied black and isort formatting as well.
  • I also made some reprod. tests and it looks good to me!

Best,

@furkanmtorun furkanmtorun self-assigned this Apr 25, 2023
@furkanmtorun furkanmtorun changed the title Integration Tests & Formatting Integration Tests & Formatting & Update CI Apr 27, 2023
straussmaximilian
straussmaximilian approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@straussmaximilian straussmaximilian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@furkanmtorun furkanmtorun merged commit 565368d into OmicLearn-v1.4 May 4, 2023
@furkanmtorun furkanmtorun deleted the tests branch May 4, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straussmaximilian straussmaximilian straussmaximilian approved these changes

Assignees

@furkanmtorun furkanmtorun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@furkanmtorun @straussmaximilian