Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #437: adds caching to calculate_deltas() #438

Merged
merged 4 commits into from
May 8, 2022
Merged

issue #437: adds caching to calculate_deltas() #438

merged 4 commits into from
May 8, 2022

Conversation

mschwoer
Copy link
Contributor

@mschwoer mschwoer commented Apr 28, 2022

ad issue #437

  • ADD stronger unit test for calculate_deltas()
    -- using more input data (3 data sets instead of one)
    -- testing also the calib=True case
    -- more detailed assertions

update

  • ADD caching to calculate_deltas()
  • ADD case "relative" to test_calculate_distance()

* issue #437: adds stronger unit test for calculate_deltas()
issue #437: add cache to calculate deltas
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mschwoer mschwoer changed the title issue #437: adds stronger unit test for calculate_deltas() issue #437: adds caching to calculate_deltas() Apr 29, 2022
@mschwoer mschwoer changed the base branch from master to develop May 5, 2022 15:14
@mschwoer
Copy link
Contributor Author

mschwoer commented May 5, 2022

just figured out that the target should be develop rather than master :-)

@straussmaximilian straussmaximilian merged commit 586d197 into MannLabs:develop May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants