Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repo and testcases #13

Merged
merged 6 commits into from
Aug 27, 2024
Merged

Conversation

GeorgWa
Copy link
Collaborator

@GeorgWa GeorgWa commented Jul 30, 2024

No description provided.

@GeorgWa GeorgWa changed the base branch from speed_improvements to main July 30, 2024 14:26
@GeorgWa GeorgWa changed the base branch from main to speed_improvements July 30, 2024 14:27
Copy link
Collaborator

@sophiamaedler sophiamaedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me :) Like the switch von shapes to polygons. Is more understandable.

im = Image.open(os.path.join(_dir, 'Image_Segmentation', 'segmentation_cytosol.tiff'))

package_base_path = pathlib.Path(__file__).parent.parent.parent.resolve().absolute()
test_segmentation_path = os.path.join(package_base_path, 'docs_source/pages/notebooks/Image_Segmentation/segmentation_cytosol.tiff')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better if we created the whole path using os.path.join here so that the code is more robust over different platforms.

@sophiamaedler sophiamaedler merged commit 6a987ba into speed_improvements Aug 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants