-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove the constraint on branch name #15
fix: remove the constraint on branch name #15
Conversation
95d703c
to
73a156e
Compare
Is it possible to add a test (or change existing tests so that they fail without your change?) |
73a156e
to
be2c6c8
Compare
I added a new test |
Don't mind me, just trying to trigger a pipeline with the brand new coverage action contributed in #25 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=======================================
Coverage ? 76.78%
=======================================
Files ? 64
Lines ? 1189
Branches ? 209
=======================================
Hits ? 913
Misses ? 272
Partials ? 4 ☔ View full report in Codecov by Sentry. |
@pfongkye did you have some time to check this MR? |
Hello, |
I replied to both of them. If you agree with them I can resolve them? |
Sorry @fleboulch but I'm not seeing your replies for this and this 🙏 |
They were in pending state... 💥 |
Thanks @fleboulch ! |
This constraint breaks the commits interaction on git branches with a
/
Steps to reproduce
/
(example:feat/my-branch
)/homer review !<ID>