Fix windows support #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manu343726
force-pushed
the
fix-windows-support
branch
from
0803d82
to
71cda21
Compare
Manu343726
force-pushed
the
fix-windows-support
branch
3 times, most recently
from
3cdc450
to
4f33584
Compare
Manu343726
force-pushed
the
fix-windows-support
branch
2 times, most recently
from
fc48962
to
8507d00
Compare
Manu343726
force-pushed
the
fix-windows-support
branch
from
0f47d61
to
cd1b2d4
Compare
Manu343726
force-pushed
the
master
branch
19 times, most recently
from
3e5e6f0
to
771a2c7
Compare
Manu343726
force-pushed
the
fix-windows-support
branch
from
d932741
to
a556f25
Compare
This commit also adds an option to use system installed SFML libraries instead of building them from sources
- CMake functions to get target include directories and other target properties are refactored to rely in a common get_target_dependencies() function that takes the full (recursive) list of target dependencies (Targets, binaries, etc). - New functions about target properties and deps: Gettings target binary dependencies (for example, the list of dlls the target depends on).
Now the target metadata JSON file is generated at build time so it has the LOCATION key pointing to the right target runtime location (Regardless you change he build type in VS IDE etc)
This commit introduces special handling of variadic templates so MSVC non-compliant shit correctly resolves calls to the right base cases. This also implied splitting the cpp::foreach() utility function into two functions cpp::foreach() (for variadic packs) and cpp::foreach_type<Ts...>() (For types).
The function just asked for target dependencies include dirs, missing the include dirs of the target itself.
Manu343726
force-pushed
the
fix-windows-support
branch
2 times, most recently
from
6be3f01
to
3e345af
Compare
Manu343726
force-pushed
the
fix-windows-support
branch
from
3e345af
to
e70b6be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.