Use AccountHandler when getting account data, reason for switch_account/switch_user #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for switch_account/switch_user
Grennith
reviewed
Jun 22, 2023
| @@ -410,7 +411,7 @@ async def _restart_pogo_safe(self): | |||
| await asyncio.sleep(1) | |||
| return await self.start_pogo() | |||
|
|
|||
| async def _switch_user(self): | |||
| async def _switch_user(self, reason=None): | |||
There was a problem hiding this comment.
Where is that reason used? What type should it have? Apparently string? Could use a type (imho enum) at this point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some missing interactions with AbstractAccountHandler, added reason to switch_user/switch_account to easier work with an external accountHandler