Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle magisk on/off after two loginfail screens #399

Merged
merged 5 commits into from
Sep 27, 2019
Merged

Toggle magisk on/off after two loginfail screens #399

merged 5 commits into from
Sep 27, 2019

Conversation

chr2002qw
Copy link
Contributor

PR´d this now against master.

Since i'am using this PR, i never looped in loginfail screens.
Added reboot for besser sucess.

Includes Grennith´s patch :-)

@Grennith
Copy link
Collaborator

Use the patch file I sent please, added methods to communicator won't be executed like that, workers will crash

@@ -76,6 +76,12 @@ def resetAppdata(self, package_name) -> bool:
def clearAppCache(self, package_name) -> bool:
return self.__runAndOk("more cache {}\r\n".format(package_name), self.__command_timeout)

def magiskOff(self, package_name) -> bool:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't ne called, see workerBase, same goes for magiskOn
Double check the patch file I sent :)

Copy link
Contributor Author

@chr2002qw chr2002qw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed typo in communicator.py :-)

Copy link
Contributor Author

@chr2002qw chr2002qw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix :)

@Grennith Grennith merged commit fa232e5 into Map-A-Droid:master Sep 27, 2019
Expl0dingBanana pushed a commit to Expl0dingBanana/MAD that referenced this pull request Oct 4, 2019
* Added magisk toggle

* Update communicator.py

* Update communicator.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants