-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show user the auto-generated layer title in importer #838
Comments
Yes! I'm all about more intentional naming. However, we might want to display the file name from the upload somewhere on this modal (but outside of the text form) for the user to reference while creating their StoryLayer title. |
Question from @Coop56:
Braindump:We load most of the importer JS scripts into the browser via our Site Scripts template here. Performance note: since the modals for Importer are part of the header menu options on every page we load these scripts (8 files) on every page. That template tag
and I'm pretty sure the template for that tag is NOT in mapstory, but in osgeo_importer so we can't control the bundling easy. We provide overwrites for some of Importer's html templates & wizards in the
As of the time of writing these notes, I haven't confirmed that we're USING them, but they're there. Of note: we do provide our own Angular controllers for:And those are tied into the mapstory angular module right now and loaded with mapstory.js Long story short, I don't believe we're overwriting |
Instead of showing the user the auto-generated name we give to layers in importer, show an empty text box. Make the text box a bit wider too. Having the auto-generated text there encourages users to just leave it. Since the auto-generated title includes an underscore that currently hurts our search, this is particularly negative. The auto-generated layer name is only a technical requirement so doesn't need to be exposed to users at any point.
Also, update the text to say:
"Giving your layer a descriptive title will make it easier for others to find. Remember to separate each word in your title with a space."
The text was updated successfully, but these errors were encountered: