Close floor component if number of floors is less or equal than 1 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This solution does not allow developers to display the floor controller even if there is only one floor available. As done for Android, I will add delegate methods that will be called on floors change. If implemented, developers will be able to display or not the floor controller depends of the available floor. |
|
I added a solution to #3 |
|
Thanks @emerciercontexeo. Will close this PR and use solution described on #3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Floor component is visible even if venue only has one floor
Solution
In this PR I close MWZComponentFloorController is number of floors 0 or 1