Add support for bright/light colors #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks pretty reasonable to me; ANSI compliance seems like something we should have ( https://en.wikipedia.org/wiki/ANSI_escape_code#Colors , https://gist.github.com/chrisopedia/8754917 ) and this doesn't break existing functionality. I will plan to merge it in in the near future. Thanks! |
|
Do you know if this also works with bold bright colors? Maybe you could add a test for that as well? |
|
Didn't expect this would get a looked at after two and a half years. 😛 I'm at work right now, but I'll take a look at this again once I'm home. |
|
+1 for this 😃 |
|
There were too many merge conflicts so I manually copy/pasted and pushed 56de9f0 . This will land in v1.4.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
randomfunction with new colors