Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker refactoring #209

Merged
merged 1 commit into from
Apr 14, 2019
Merged

Tracker refactoring #209

merged 1 commit into from
Apr 14, 2019

Conversation

tagantroy
Copy link
Contributor

@tagantroy tagantroy commented Apr 10, 2019

I moved state transition handling from NoOpTracker to TestResultReporter
This MR is preparation for #186

@codecov-io
Copy link

codecov-io commented Apr 10, 2019

Codecov Report

Merging #209 into develop will decrease coverage by 0.22%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #209      +/-   ##
============================================
- Coverage      58.62%   58.4%   -0.23%     
+ Complexity       340     339       -1     
============================================
  Files             97      97              
  Lines           1779    1784       +5     
  Branches         222     222              
============================================
- Hits            1043    1042       -1     
- Misses           616     622       +6     
  Partials         120     120
Impacted Files Coverage Δ Complexity Δ
...iy/marathon/analytics/tracker/DelegatingTracker.kt 100% <100%> (ø) 5 <1> (+1) ⬆️
...alinskiy/marathon/analytics/tracker/NoOpTracker.kt 100% <100%> (+24%) 5 <3> (-6) ⬇️
...kiy/marathon/execution/queue/TestResultReporter.kt 56.06% <50%> (-4.41%) 7 <4> (+4)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41f1c56...e970e8e. Read the comment docs.

Copy link
Member

@Malinskiy Malinskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tagantroy tagantroy merged commit 5e5f332 into develop Apr 14, 2019
@tagantroy tagantroy deleted the cleanup_tracker branch April 14, 2019 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants