AndroidDeviceTestRunner now checks if test contains the @Ignore #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filters these tests out One edge-case is when the batch consists of only ignored tests, in this case Android's test runner will output exception but it doesn't break anything in the marathon
Codecov Report
@@ Coverage Diff @@
## develop #226 +/- ##
==========================================
Coverage 58.46% 58.46%
Complexity 342 342
==========================================
Files 97 97
Lines 1789 1789
Branches 222 222
==========================================
Hits 1046 1046
Misses 622 622
Partials 121 121Continue to review full report at Codecov.
|
tagantroy
approved these changes
May 12, 2019
Malinskiy
deleted the
feature/handle_gnore_annotation_for_android_properly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AndroidDeviceTestRunner filters the @ignore test classes out now without sending them to the device
One edge-case is when the batch consists of only ignored tests, in this
case Android's test runner will output exception but it doesn't break
anything in the marathon
Fixes #186