Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests for horizontal number picker, changed UI of example app #44

Merged
merged 8 commits into from
Aug 1, 2019
Merged

Added tests for horizontal number picker, changed UI of example app #44

merged 8 commits into from
Aug 1, 2019

Conversation

moniaS
Copy link
Contributor

@moniaS moniaS commented Jul 31, 2019

No description provided.

MarcinusX
MarcinusX requested changes Jul 31, 2019
View reviewed changes
lib/numberpicker.dart Outdated Show resolved Hide resolved
lib/numberpicker.dart Outdated Show resolved Hide resolved
lib/numberpicker.dart Show resolved Hide resolved
lib/numberpicker.dart Outdated Show resolved Hide resolved
lib/numberpicker.dart Outdated Show resolved Hide resolved
lib/numberpicker.dart Outdated Show resolved Hide resolved
@MarcinusX
Copy link
Owner

Resolves #28
Closes #33

@MarcinusX MarcinusX merged commit 5374653 into MarcinusX:master Aug 1, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 25

  • 36 of 49 (73.47%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 71.491%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/numberpicker.dart 36 49 73.47%
Files with Coverage Reduction New Missed Lines %
lib/numberpicker.dart 3 71.49%
Totals Coverage Status
Change from base Build 16: -0.3%
Covered Lines: 163
Relevant Lines: 228
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcinusX MarcinusX MarcinusX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moniaS @MarcinusX @coveralls @pedromassango