-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add color for selected value as selectedValueColor #69
Conversation
I suggest completely passing in a TextStyle for the And the default style as well. |
That would be good , but he wont merge it anyway :) |
Hey, can we have 2 params in here? One for |
Done :) |
@@ -257,10 +269,6 @@ class NumberPicker extends StatelessWidget { | |||
} | |||
|
|||
Widget _integerListView(ThemeData themeData) { | |||
TextStyle defaultStyle = themeData.textTheme.body1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should still use those styles if user didn't provide any styles.
I believe it go like that:
TextStyle defaultStyle = textStyle ?? themeData.textTheme.body1;
TextStyle selectedStyle =
selectedTextStyle ?? themeData.textTheme.headline.copyWith(color: themeData.accentColor);
Same in other ocurrences
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, could you undo all new formatting? :) So that in one PR we can only see those changes that are important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sry for that format problem :\
I didn't change them , this ide decide to change them :(
btw I fix them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any news on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's complete, we waiting for accepting the pull request :)
Thanks for merging @MarcinusX ! 🎉 |
I think the color of selected value would be needed most of time.