🐛 fix: When linking inheritedType, if the name includes &, separate and link it
#82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
==========================================
+ Coverage 94.56% 94.60% +0.03%
==========================================
Files 25 25
Lines 956 963 +7
==========================================
+ Hits 904 911 +7
Misses 52 52 ☔ View full report in Codecov by Sentry. |
|
Thanks @TTOzzi for this PR .. even including covering unit test .. I LOVE IT 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #80
This PR implements the workaround for #80.
If the
nameininheritedTypesreceived fromSourceKittencontains an&delimiter, it separates them to link the inheritance relationships.If arbitrarily modifying the syntax structure parsed by
SourceKittendoes not align with the project's direction, feel free to close this PR.