Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue: (#392)
What does this Pull Request do?
Changes shutdown hook scripts from running in the background to running in the foreground.
What's new?
As per the discussion in #392, we can't think of any reason to have shutdown hook scripts run as background processes. This PR replaces the code that allowed the scripts to run as a background process with a simple PHP
exec()
call.How should this be tested?
This PR requires a smoke test; there are no PHPUnit tests to cover it.
To test:
mv
) all the files in the unzipped directory starting withissue-392*
into your mik directory../mik -c issue-392.ini
. You should see the following ouput:and your /tmp/directory should contain a file
/tmp/hey.txt
.Additional Notes
We will need to update https://github.com/MarcusBarnes/mik/wiki/Shutdown-hooks.
Interested parties
@jpeak5 @MarcusBarnes