Skip to content

Reduce the use of 3rd party code in the crawler #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 20, 2025
Merged

Reduce the use of 3rd party code in the crawler #150

merged 3 commits into from
Jan 20, 2025

Conversation

vlofgren
Copy link
Contributor

@vlofgren vlofgren commented Jan 19, 2025 •
edited
Loading

  • Migrate away from using OkHttp in the crawler, use Java's HttpClient instead
  • Roll our own sitemap parser instead of using Apache's implementation, as that was causing memory issues

This change may give us issues with connections stuck in TIME_WAIT, as HttpClient doesn't support setting SO_LINGER.

@vlofgren vlofgren changed the title Migrate away from using OkHttp in the crawler, use Java's HttpClient instead Reduce the use of 3rd party code in the crawler Jan 20, 2025
@vlofgren vlofgren merged commit 2c67f50 into master Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vlofgren