Skip to content

Commit

Permalink
MDEV-27217 ha_partition::start_stmt() ignored error fix
Browse files Browse the repository at this point in the history
ha_partition::start_stmt() continued processing in error state. Though
no known bug cases yet it seems break was made incorrect by
f93a2a3 (2016) while originally break was ok since cd483c5
(2005).
  • Loading branch information
midenok committed Jan 13, 2022
1 parent 4d5ae2b commit 7c61fb2
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions sql/ha_partition.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4082,11 +4082,10 @@ int ha_partition::start_stmt(THD *thd, thr_lock_type lock_type)
i= bitmap_get_next_set(&m_part_info->lock_partitions, i))
{
if (unlikely((error= m_file[i]->start_stmt(thd, lock_type))))
break;
DBUG_RETURN(error);
/* Add partition to be called in reset(). */
bitmap_set_bit(&m_partitions_to_reset, i);
}
// FIXME: check error?
switch (lock_type)
{
case TL_WRITE_ALLOW_WRITE:
Expand Down

0 comments on commit 7c61fb2

Please sign in to comment.