Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve serializer registration #3914

Merged
merged 3 commits into from
May 5, 2024
Merged

Improve serializer registration #3914

merged 3 commits into from
May 5, 2024

Conversation

StefanOssendorf
Copy link
Contributor

Replace SerializationFormatter(Type formatterType) with a typesafe equivalent using generics.

Changed SerializationFormatter(Type formatterType) to SerializationFormatter<T>() where T: ISerializationFormatter because the resulting instance is hard castet to ISerializationFormatter.

@rockfordlhotka rockfordlhotka self-requested a review May 4, 2024 22:23
@StefanOssendorf StefanOssendorf merged commit 89bc195 into main May 5, 2024
1 check passed
@StefanOssendorf StefanOssendorf deleted the dev/improve-serializer-registration branch May 5, 2024 07:01
@JasonBock JasonBock mentioned this pull request May 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rockfordlhotka rockfordlhotka rockfordlhotka approved these changes

Assignees
No one assigned
Labels
flag/breaking change kind/enhancement kind/technical debt
Projects
CSLA Version 9.0.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanOssendorf @rockfordlhotka