Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specification of variable ordering in discrete marginal computation #18

Merged
merged 4 commits into from
Dec 1, 2021
Merged

Allow specification of variable ordering in discrete marginal computation #18

merged 4 commits into from
Dec 1, 2021

Conversation

keevindoherty
Copy link
Collaborator

Straightforward wrapper around gtsam::DiscreteMarginals allowing for different variable ordering choices, or even custom orderings.

Branches off of feature/emfactors so we should merge that into main first.

@keevindoherty
Copy link
Collaborator Author

Also note: specifying natural ordering appears to address #16

@keevindoherty keevindoherty mentioned this pull request Nov 30, 2021
Closed
520xyxyzq
520xyxyzq reviewed Nov 30, 2021
View reviewed changes
Copy link

@520xyxyzq 520xyxyzq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@keevindoherty keevindoherty merged commit 1a35f4b into feature/emfactors Dec 1, 2021
@keevindoherty keevindoherty deleted the feature/discrete-ordering branch December 15, 2021 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@520xyxyzq 520xyxyzq 520xyxyzq left review comments

@kurransingh kurransingh Awaiting requested review from kurransingh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keevindoherty @520xyxyzq