Update Test for Version 2.11.0 #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbriannl
changed the title
nbriannl
requested review from
openorclose,
ang-zeyu,
marvinchin and
yamgent
openorclose
approved these changes
Feb 26, 2020
marvinchin
approved these changes
Feb 26, 2020
|
Thanks for spotting this. I am leaving it to @marvinchin to merge so that he can test out his new merging powers. :P On an unrelated note, this probably should be fixed in the long run by mocking the version number, so that we don't have to update the tests every release (this should be done in a separate PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [ ] Documentation update
• [ ] Bug fix
• [ ] New feature
• [ ] Enhancement to an existing feature
• [X] Other, please explain: Build is failing due to test file not updated.
What is the rationale for this request?
Build is failing. Updating test reveals one file is not updated.
What changes did you make? (Give an overview)
Update file
Proposed commit message: (wrap lines at 72 characters)
Update expected output for test