Padding before title #1625
Merged
Padding before title #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahtanjz
reviewed
Jul 4, 2021
There was a problem hiding this comment.
Thanks for working on this @MorningLit 👍
A few suggestions:
Wonder if it is better to add it here instead so that it will be applied to current markbind sites as well. Adding it inside core/template will only affect newly init sites.
0.3125rem still seems a little tight, maybe can try out 0.5rem?
You may also want to run npm run lintfix and then npm run test first before pushing to lint and ensure all tests are passing.
|
Appreciate the feedback @jonahtanjz ! The new updated padding |
jonahtanjz
reviewed
Jul 4, 2021
|
Updated my PR based on your comments 👍 |
jonahtanjz
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Fixes #1614
Overview of changes:
Hi dev team, I am sending this PR here, as told by Prof Damith, because I am unsure if my fix is the correct approach. Do let me know what did I do wrong and where can I improve it!
Added a padding-left of 0.3125 rem which is the same as the element's padding-top and padding-bottom.
Anything you'd like to highlight / discuss:
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Add left padding to page nav title
Checklist: ☑️