Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all heading id assignment to after postprocess #1635

Merged
merged 1 commit into from
Jul 18, 2021

Conversation

ang-zeyu
Copy link
Contributor

@ang-zeyu ang-zeyu commented Jul 18, 2021

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • Others, please explain:

Fixes part of #1607

Another regression from #1403

Overview of changes:

  • Move all heading id assignment to after postprocess
  • Introduce another plugin api postProcessNode for the anchors plugin, so it can extract heading ids after the heading id assignment (internal and undocumented for now)

Anything you'd like to highlight / discuss:

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)
Move all heading id assignment to after postprocess


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No blatantly unrelated changes
  • Pinged someone for a review!

@ang-zeyu ang-zeyu merged commit 5480194 into MarkBind:master Jul 18, 2021
@ang-zeyu ang-zeyu added this to the v3.0.6 milestone Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant