Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove effect attribute from tests #1783

Merged
merged 2 commits into from
Feb 21, 2022

Conversation

jovyntls
Copy link
Contributor

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • Others, please explain:

Overview of changes:
Remove the use of the effect attribute in the tests, as it is not implemented and has no effect.
Related changes to the documentation were made in #1777

Anything you'd like to highlight / discuss:
N/A

Testing instructions:
N/A

Proposed commit message: (wrap lines at 72 characters)

Remove unused effect attribute from tests

Currently, the effect attribute is not implemented for both popovers 
and tooltips. However, it is included in some of the tests for these 
components. This may be confusing and clutter the codebase. 

Let's remove the effect attribute from these tests, to avoid confusion 
on whether or not this is a valid attribute.

Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

@jovyntls jovyntls changed the title Remove effect from tests Remove effect attribute from tests Feb 20, 2022
Copy link
Contributor

@ryoarmanda ryoarmanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryoarmanda ryoarmanda added this to the 4.0 milestone Feb 20, 2022
@jonahtanjz jonahtanjz merged commit a6512dc into MarkBind:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants